Re: [PATCH 07/16] codebase: prepare to remove cpu.h from exec/exec-all.h

[Richard Henderson <richard.henderson@linaro.org>]

On 3/9/25 21:58, Pierrick Bouvier wrote:
> diff --git a/page-vary-target.c b/page-vary-target.c
> index 3f81144cda8..12fda410bb0 100644
> --- a/page-vary-target.c
> +++ b/page-vary-target.c
> @@ -20,8 +20,9 @@
>   #define IN_PAGE_VARY 1
>   
>   #include "qemu/osdep.h"
> -#include "exec/page-vary.h"
>   #include "exec/exec-all.h"
> +#include "exec/page-vary.h"
> +#include "exec/target_page.h"

You can remove exec-all.h here.

> diff --git a/target/riscv/bitmanip_helper.c b/target/riscv/bitmanip_helper.c
> index b99c4a39a1f..d93312a811c 100644
> --- a/target/riscv/bitmanip_helper.c
> +++ b/target/riscv/bitmanip_helper.c
> @@ -21,6 +21,7 @@
>   #include "qemu/osdep.h"
>   #include "qemu/host-utils.h"
>   #include "exec/exec-all.h"
> +#include "exec/target_long.h"
>   #include "exec/helper-proto.h"
>   #include "tcg/tcg.h"

Likewise.

With that,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~