From: "Arnout Engelen" <arnout@bzzt.net>
To: "Gerd Hoffmann" <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH] hw/usb/hcd-ehci.c: print diagnostics when cpage out of range
Date: Thu, 09 Jun 2022 12:13:58 +0200 [thread overview]
Message-ID: <2d63230e-6b0c-4e4f-af9a-632ec00ca19f@www.fastmail.com> (raw)
In-Reply-To: <20220609100955.ybq55nbapi2ach47@sirius.home.kraxel.org>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Thu, Jun 9, 2022, at 12:09, Gerd Hoffmann wrote:
> Hi,
>
> > if (cpage > 4) {
> > fprintf(stderr, "cpage out of range (%u)\n", cpage);
> > + bytes = get_field(p->qtd.token, QTD_TOKEN_TBYTES);
> > + offset = p->qtd.bufptr[0] & ~QTD_BUFPTR_MASK;
> > + cpage = get_field(p->qtd.token, QTD_TOKEN_CPAGE);
> > + fprintf(stderr, "reading %u bytes from offset %u at page %u\n",
> > + bytes, offset, cpage);
>
> I think we should either drop it (you've successfully debugged the
> problem meanwhile, thanks for that), or turn it into a tracepoint.
> Simply printing to stderr is deprecated.
Gotcha, I'm OK with dropping it. Thanks for the feedback & queue-ing the fix!
Kind regards,
Arnout
[-- Attachment #2: Type: text/html, Size: 1718 bytes --]
prev parent reply other threads:[~2022-06-09 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 8:25 [PATCH] hw/usb/hcd-ehci.c: print diagnostics when cpage out of range Arnout Engelen
2022-06-09 10:09 ` Gerd Hoffmann
2022-06-09 10:13 ` Arnout Engelen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d63230e-6b0c-4e4f-af9a-632ec00ca19f@www.fastmail.com \
--to=arnout@bzzt.net \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).