From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Sönke Holz" <sholz8530@gmail.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>
Subject: Re: [PATCH] contrib/plugins/uftrace_symbols.py: unbreak --no-prefix-symbols
Date: Fri, 5 Dec 2025 06:03:04 -0800 [thread overview]
Message-ID: <2d7b3576-9ebd-4124-aa80-7ea18526189a@linaro.org> (raw)
In-Reply-To: <77c23b93-249b-4e0f-b26b-130a3c66c248@linaro.org>
On 12/5/25 6:02 AM, Pierrick Bouvier wrote:
> On 12/5/25 2:56 AM, Sönke Holz wrote:
>> Since 8a545a336d, `name` is unbound if --no-prefix-symbols is passed,
>> causing this script to break when that option is set.
>>
>> Signed-off-by: Sönke Holz <sholz8530@gmail.com>
>> ---
>> contrib/plugins/uftrace_symbols.py | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/contrib/plugins/uftrace_symbols.py b/contrib/plugins/uftrace_symbols.py
>> index 45fb79c7a5..21704541a6 100755
>> --- a/contrib/plugins/uftrace_symbols.py
>> +++ b/contrib/plugins/uftrace_symbols.py
>> @@ -98,6 +98,8 @@ def generate_symbol_file(self, prefix_symbols):
>> size = f'{s.size:{addrx}}'
>> if prefix_symbols:
>> name = f'{binary_name}:{s.name}'
>> + else:
>> + name = s.name
>> print(addr, size, 'T', name, file=sym_file)
>>
>> def generate_debug_file(self):
>
> Thanks for catching it, I was indeed always using this option for testing.
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>
@alex.bennée, any chance it can be integrated for release, when you will
pull Final fixes for 10.2?
Thanks,
Pierrick
next prev parent reply other threads:[~2025-12-05 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 10:56 [PATCH] contrib/plugins/uftrace_symbols.py: unbreak --no-prefix-symbols Sönke Holz
2025-12-05 14:02 ` Pierrick Bouvier
2025-12-05 14:03 ` Pierrick Bouvier [this message]
2025-12-05 15:18 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d7b3576-9ebd-4124-aa80-7ea18526189a@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sholz8530@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).