From: David Hildenbrand <david@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Chenyi Qiang <chenyi.qiang@intel.com>
Subject: Re: [PATCH] virtio-mem: Fix typo in function name
Date: Wed, 28 Dec 2022 14:52:23 +0100 [thread overview]
Message-ID: <2d847cbf-687b-cd44-7737-393a96460d7f@redhat.com> (raw)
In-Reply-To: <20221228130956.80515-1-philmd@linaro.org>
On 28.12.22 14:09, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/virtio/virtio-mem.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
> index d96bde1fab..c252027391 100644
> --- a/hw/virtio/virtio-mem.c
> +++ b/hw/virtio/virtio-mem.c
> @@ -207,7 +207,7 @@ static int virtio_mem_for_each_unplugged_range(const VirtIOMEM *vmem, void *arg,
> *
> * Returns false if the intersection is empty, otherwise returns true.
> */
> -static bool virito_mem_intersect_memory_section(MemoryRegionSection *s,
> +static bool virtio_mem_intersect_memory_section(MemoryRegionSection *s,
> uint64_t offset, uint64_t size)
> {
> uint64_t start = MAX(s->offset_within_region, offset);
> @@ -245,7 +245,7 @@ static int virtio_mem_for_each_plugged_section(const VirtIOMEM *vmem,
> first_bit + 1) - 1;
> size = (last_bit - first_bit + 1) * vmem->block_size;
>
> - if (!virito_mem_intersect_memory_section(&tmp, offset, size)) {
> + if (!virtio_mem_intersect_memory_section(&tmp, offset, size)) {
> break;
> }
> ret = cb(&tmp, arg);
> @@ -277,7 +277,7 @@ static int virtio_mem_for_each_unplugged_section(const VirtIOMEM *vmem,
> first_bit + 1) - 1;
> size = (last_bit - first_bit + 1) * vmem->block_size;
>
> - if (!virito_mem_intersect_memory_section(&tmp, offset, size)) {
> + if (!virtio_mem_intersect_memory_section(&tmp, offset, size)) {
> break;
> }
> ret = cb(&tmp, arg);
> @@ -313,7 +313,7 @@ static void virtio_mem_notify_unplug(VirtIOMEM *vmem, uint64_t offset,
> QLIST_FOREACH(rdl, &vmem->rdl_list, next) {
> MemoryRegionSection tmp = *rdl->section;
>
> - if (!virito_mem_intersect_memory_section(&tmp, offset, size)) {
> + if (!virtio_mem_intersect_memory_section(&tmp, offset, size)) {
> continue;
> }
> rdl->notify_discard(rdl, &tmp);
> @@ -329,7 +329,7 @@ static int virtio_mem_notify_plug(VirtIOMEM *vmem, uint64_t offset,
> QLIST_FOREACH(rdl, &vmem->rdl_list, next) {
> MemoryRegionSection tmp = *rdl->section;
>
> - if (!virito_mem_intersect_memory_section(&tmp, offset, size)) {
> + if (!virtio_mem_intersect_memory_section(&tmp, offset, size)) {
> continue;
> }
> ret = rdl->notify_populate(rdl, &tmp);
> @@ -346,7 +346,7 @@ static int virtio_mem_notify_plug(VirtIOMEM *vmem, uint64_t offset,
> if (rdl2 == rdl) {
> break;
> }
> - if (!virito_mem_intersect_memory_section(&tmp, offset, size)) {
> + if (!virtio_mem_intersect_memory_section(&tmp, offset, size)) {
> continue;
> }
> rdl2->notify_discard(rdl2, &tmp);
Yeah, I already included a fix in a different series that I yet have to
follow up:
https://lkml.kernel.org/r/20211013103330.26869-12-david@redhat.com
Most probably I'll simply queue this fix here.
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2022-12-28 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 13:09 [PATCH] virtio-mem: Fix typo in function name Philippe Mathieu-Daudé
2022-12-28 13:52 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d847cbf-687b-cd44-7737-393a96460d7f@redhat.com \
--to=david@redhat.com \
--cc=chenyi.qiang@intel.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).