From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines
Date: Fri, 16 Jun 2017 17:55:30 +0200 [thread overview]
Message-ID: <2d873cf2-11cd-1a2c-30e9-07d506685d37@redhat.com> (raw)
In-Reply-To: <76504ef2-8dd0-ecbc-6e25-55be6abcb14a@redhat.com>
On 16/06/2017 17:21, Thomas Huth wrote:
>> Why do you say they can't be moved? They can, and your series should
>> change nothing about it, thanks to what you're doing now with
>> CONFIG_KVM_IS_POSSIBLE (which was also done before with NEED_CPU_H).
> numa.c and balloon.c both use ram_addr_t (numa.c uses it directly, and
> balloon.c indirectly via the QEMUBalloonEvent typedef from the header).
> And ram_addr_t is currently target-specific - it depends on
> CONFIG_XEN_BACKEND. So this could break in certain subtle cases, e.g.
> when compiling on a 32-bit host with XEN enabled.
Can ram_addr_t be poisoned on target-independent files?
Paolo
next prev parent reply other threads:[~2017-06-16 15:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 14:59 [Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines Thomas Huth
2017-06-16 14:59 ` [Qemu-devel] [PATCH 1/7] include/exec/poison: Add missing TARGET defines Thomas Huth
2017-06-16 14:59 ` [Qemu-devel] [PATCH 2/7] include/exec/poison: Mark some CONFIG defines as poisoned, too Thomas Huth
2017-06-16 14:59 ` [Qemu-devel] [PATCH 3/7] Move CONFIG_KVM related definitions to kvm_i386.h Thomas Huth
2017-06-16 14:59 ` [Qemu-devel] [PATCH 4/7] include/exec/poison: Mark CONFIG_KVM as poisoned, too Thomas Huth
2017-06-16 14:59 ` [Qemu-devel] [PATCH 5/7] cpu: Introduce a wrapper for tlb_flush() that can be used in common code Thomas Huth
2017-06-16 17:07 ` Alex Bennée
2017-06-16 17:24 ` Paolo Bonzini
2017-06-16 14:59 ` [Qemu-devel] [PATCH 6/7] include/exec/poison: Mark CONFIG_SOFTMMU as poisoned Thomas Huth
2017-06-16 14:59 ` [Qemu-devel] [PATCH 7/7] Makefile: Move bootdevice.o to common-obj-y Thomas Huth
2017-06-16 15:05 ` [Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines Paolo Bonzini
2017-06-16 15:21 ` Thomas Huth
2017-06-16 15:55 ` Paolo Bonzini [this message]
2017-06-16 16:15 ` Thomas Huth
2017-06-16 16:19 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d873cf2-11cd-1a2c-30e9-07d506685d37@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).