From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj3HU-000743-VU for qemu-devel@nongnu.org; Mon, 14 Jan 2019 09:32:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj3HT-0003mH-26 for qemu-devel@nongnu.org; Mon, 14 Jan 2019 09:32:00 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37207) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gj3HS-0003kK-S3 for qemu-devel@nongnu.org; Mon, 14 Jan 2019 09:31:58 -0500 Received: by mail-wm1-f68.google.com with SMTP id g67so9041428wmd.2 for ; Mon, 14 Jan 2019 06:31:58 -0800 (PST) References: <1547473614-20033-1-git-send-email-thuth@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <2d8dad3d-05a1-7c16-4640-1df9e2b82642@redhat.com> Date: Mon, 14 Jan 2019 15:31:55 +0100 MIME-Version: 1.0 In-Reply-To: <1547473614-20033-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Peter Maydell , qemu-devel@nongnu.org, berrange@redhat.com Cc: Paolo Bonzini , Peter Lieven , qemu-block@nongnu.org, Ronnie Sahlberg On 1/14/19 2:46 PM, Thomas Huth wrote: > The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad > "inline" prototype definitions which GCC refuses to compile in its > gnu99 mode: > > In file included from block/iscsi.c:52:0: > /usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline function > ‘scsi_set_uint16’ declared but never defined [-Werror] > inline void scsi_set_uint16(unsigned char *c, uint16_t val); > ^ > /usr/include/iscsi/scsi-lowlevel.h:809:13: error: inline function > ‘scsi_set_uint32’ declared but never defined [-Werror] > inline void scsi_set_uint32(unsigned char *c, uint32_t val); > ^ > > This has been fixed by upstream libiscsi in version 1.10.0 (see > https://github.com/sahlberg/libiscsi/commit/7692027d6c11 ), but > since we still want to support 1.9.0 for CentOS 7 / RHEL7, we > have to work-around the issue by compiling with "-fgnu89-inline" > in this case instead. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Thomas Huth > --- > configure | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/configure b/configure > index 2b9ba7d..aa80c17 100755 > --- a/configure > +++ b/configure > @@ -4562,6 +4562,11 @@ if test "$libiscsi" != "no" ; then > libiscsi="yes" > libiscsi_cflags=$($pkg_config --cflags libiscsi) > libiscsi_libs=$($pkg_config --libs libiscsi) > + if $pkg_config --exact-version==1.9.0 libiscsi; then The first offending commit is d327ab09c which got included in 1.8.0, so using "exact" is not correct. Maybe: if ! $pkg_config --atleast-version=1.10 libiscsi; then > + # There are some bad inline declarations in scsi-lowlevel.h of > + # libiscsi 1.9.0 which don't work in gnu99 mode without this: > + libiscsi_cflags="-fgnu89-inline $libiscsi_cflags" > + fi > else > if test "$libiscsi" = "yes" ; then > feature_not_found "libiscsi" "Install libiscsi >= 1.9.0" >