From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guenR-0005tk-1l for qemu-devel@nongnu.org; Fri, 15 Feb 2019 09:48:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1guenQ-0006fE-7h for qemu-devel@nongnu.org; Fri, 15 Feb 2019 09:48:56 -0500 References: <20190214140714.15738-1-imammedo@redhat.com> <4d8518f7-5272-fc18-d5c7-20c4cafdf7e8@redhat.com> <20190215123317.6903b818@Igors-MacBook-Pro.local> From: Paolo Bonzini Message-ID: <2d99aca8-5ed0-bea3-4a4f-7b2a8e89b049@redhat.com> Date: Fri, 15 Feb 2019 15:48:43 +0100 MIME-Version: 1.0 In-Reply-To: <20190215123317.6903b818@Igors-MacBook-Pro.local> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] memory: use memory_region_init_ram() instead of memory_region_allocate_system_memory() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, ehabkost@redhat.com, mark.cave-ayland@ilande.co.uk, qemu-arm@nongnu.org, jan.kiszka@web.de, atar4qemu@gmail.com On 15/02/19 12:33, Igor Mammedov wrote: > On Thu, 14 Feb 2019 19:11:27 +0100 > Paolo Bonzini wrote: > >> On 14/02/19 15:07, Igor Mammedov wrote: >>> Also some boards (ab)use memory_region_allocate_system_memory(), calling it several >>> times to allocate various fixed sized chunks of RAM and ROMs, which is problematic >>> to map to a single initial RAM Machine::memdev backend and is currently broken if >>> -mem-path points to a not hugepage pool. >> >> This is certainly a good idea. However, I'm not sure why you would need >> a memdev property on the Machine instead of just allowing 1 -numa node, >> which is what really is. > > using '-numa node' would be confusing to user when he/she is not interested in numa usecase > it also would enable numa fdt/acpi parts generated automatically (fixable but then again > it adds more to confusion) and in the end there are boards that do not support numa at all > (s390x). Fair enough. What about -m, too? Then you'd specify a memdev instead of the initial memory size. Paolo