qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Daniel Henrique Barboza <danielhb413@gmail.com>,
	Murilo Opsfelder Araujo <muriloo@linux.ibm.com>,
	qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	mopsfelder@gmail.com,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Fabiano Rosas" <farosas@linux.ibm.com>
Subject: Re: [PATCH v3] mos6522: fix linking error when CONFIG_MOS6522 is not set
Date: Mon, 16 May 2022 16:33:08 +0200	[thread overview]
Message-ID: <2d9f4a3c-aae5-f407-e8ea-2762de5ad4a2@redhat.com> (raw)
In-Reply-To: <aca5b885-daea-bb59-e79e-3317e3854cf3@gmail.com>

On 16/05/2022 16.14, Daniel Henrique Barboza wrote:
> 
> 
> On 5/10/22 20:54, Murilo Opsfelder Araujo wrote:
>> When CONFIG_MOS6522 is not set, building ppc64-softmmu target fails:
>>
>>      /usr/bin/ld: 
>> libqemu-ppc64-softmmu.fa.p/monitor_misc.c.o:(.data+0x1158): undefined 
>> reference to `hmp_info_via'
>>
>> Make devices configuration available in hmp-commands*.hx and check for
>> CONFIG_MOS6522.
>>
>> Fixes: 409e9f7131e5 (mos6522: add "info via" HMP command for debugging)
>> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
>> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>> Cc: Fabiano Rosas <farosas@linux.ibm.com>
>> Cc: Thomas Huth <thuth@redhat.com>
>> ---
> 
> Thomas,
> 
> 
> Are you going to pick this up via your misc patches tree? If not I can take it
> via ppc64.

I didn't queue it yet, so please take through your ppc branch.

  Thomas



  reply	other threads:[~2022-05-16 15:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 23:54 [PATCH v3] mos6522: fix linking error when CONFIG_MOS6522 is not set Murilo Opsfelder Araujo
2022-05-11  6:19 ` Thomas Huth
2022-05-16 14:14 ` Daniel Henrique Barboza
2022-05-16 14:33   ` Thomas Huth [this message]
2022-05-17 19:03     ` Daniel Henrique Barboza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d9f4a3c-aae5-f407-e8ea-2762de5ad4a2@redhat.com \
    --to=thuth@redhat.com \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=farosas@linux.ibm.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mopsfelder@gmail.com \
    --cc=muriloo@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).