From: Eric Blake <eblake@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
David Gibson <david@gibson.dropbear.id.au>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Andrea Bolognani <abologna@redhat.com>
Subject: Re: [Qemu-devel] [PATCH qemu v2] qmp: Add qom-list-properties to list QOM object properties
Date: Thu, 1 Mar 2018 14:18:53 -0600 [thread overview]
Message-ID: <2dad9d81-c83f-d6fb-30a6-380a8cdb70bc@redhat.com> (raw)
In-Reply-To: <ae263ebe-d0d2-3b1d-b2ac-200772eb9154@ozlabs.ru>
On 03/01/2018 05:47 AM, Alexey Kardashevskiy wrote:
>>> +##
>>> +{ 'struct': 'QOMPropertyInfo',
>>> + 'data': { 'name': 'str', 'type': 'str', '*description': 'str' } }
>>
>> So, this has identical contents to DevicePropertyInfo, and is very
>> similar to ObjectPropertyInfo. Is there any way we could consolidate
>> those types?
>
> Sure, I can get rid of DevicePropertyInfo in favour of QOMPropertyInfo, I
> am just not sure if this typename is visible anywhere in the QMP protocol.
Introspection doesn't expose type names; you are free to change those at
will (clients like libvirt that parse introspection merely get a list of
members and types, regardless of what typename those members belonged to).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-03-01 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 8:22 [Qemu-devel] [PATCH qemu v2] qmp: Add qom-list-properties to list QOM object properties Alexey Kardashevskiy
2018-02-28 14:42 ` Andrea Bolognani
2018-03-02 10:09 ` Andrea Bolognani
2018-03-01 3:59 ` David Gibson
2018-03-01 11:47 ` Alexey Kardashevskiy
2018-03-01 11:49 ` Paolo Bonzini
2018-03-01 20:18 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dad9d81-c83f-d6fb-30a6-380a8cdb70bc@redhat.com \
--to=eblake@redhat.com \
--cc=abologna@redhat.com \
--cc=aik@ozlabs.ru \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).