From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 09/11] qom: Have class_init() take a const data argument
Date: Mon, 10 Feb 2025 18:22:54 +0100 [thread overview]
Message-ID: <2db2d180-b134-4cfe-a5be-b8542aff4bac@linaro.org> (raw)
In-Reply-To: <37042664-844b-4376-ac35-6426b5e34c5d@linaro.org>
On 10/2/25 17:51, Richard Henderson wrote:
> On 2/10/25 05:31, Philippe Mathieu-Daudé wrote:
>> --- a/include/hw/core/cpu.h
>> +++ b/include/hw/core/cpu.h
>> @@ -170,7 +170,7 @@ struct CPUClass {
>> void (*disas_set_info)(CPUState *cpu, disassemble_info *info);
>> const char *deprecation_note;
>> - struct AccelCPUClass *accel_cpu;
>> + const struct AccelCPUClass *accel_cpu;
>
> This to have been split out previously.
> It's certainly not gsed material.
Yes, mis-rebased with I misunderstood object_child_foreach() pattern.
(good eyes!)
> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Thanks!
next prev parent reply other threads:[~2025-02-10 17:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 13:31 [PATCH v2 00/11] qom: Constify class_data Philippe Mathieu-Daudé
2025-02-10 13:31 ` [PATCH v2 01/11] target/i386: Constify X86CPUModel uses Philippe Mathieu-Daudé
2025-02-10 16:30 ` Richard Henderson
2025-02-10 13:31 ` [PATCH v2 02/11] target/sparc: Constify SPARCCPUClass::cpu_def Philippe Mathieu-Daudé
2025-02-10 16:30 ` Richard Henderson
2025-02-10 13:31 ` [PATCH v2 03/11] target/xtensa: Finalize config in xtensa_register_core() Philippe Mathieu-Daudé
2025-02-10 16:30 ` Richard Henderson
2025-02-10 17:02 ` Max Filippov
2025-02-10 13:31 ` [PATCH v2 04/11] target/riscv: Declare RISCVCPUClass::misa_mxl_max as RISCVMXL Philippe Mathieu-Daudé
2025-02-10 16:31 ` Richard Henderson
2025-02-10 13:31 ` [PATCH v2 05/11] target/riscv: Convert misa_mxl_max using GLib macros Philippe Mathieu-Daudé
2025-02-10 16:34 ` Richard Henderson
2025-02-10 13:31 ` [PATCH v2 06/11] hw: Declare various const data as 'const' Philippe Mathieu-Daudé
2025-02-10 16:35 ` Richard Henderson
2025-02-10 13:31 ` [PATCH v2 07/11] hw: Make class data 'const' Philippe Mathieu-Daudé
2025-02-10 16:36 ` Richard Henderson
2025-02-10 13:31 ` [PATCH v2 08/11] qom: Have class_base_init() take a const data argument Philippe Mathieu-Daudé
2025-02-10 16:36 ` Richard Henderson
2025-02-10 13:31 ` [PATCH v2 09/11] qom: Have class_init() " Philippe Mathieu-Daudé
2025-02-10 16:51 ` Richard Henderson
2025-02-10 17:22 ` Philippe Mathieu-Daudé [this message]
2025-02-10 13:31 ` [PATCH v2 10/11] qom: Constify TypeInfo::class_data Philippe Mathieu-Daudé
2025-02-10 16:54 ` Richard Henderson
2025-02-10 13:31 ` [PATCH v2 11/11] qom: Constify InterfaceInfo[] interfaces Philippe Mathieu-Daudé
2025-02-10 16:55 ` Richard Henderson
2025-02-10 13:46 ` [PATCH v2 00/11] qom: Constify class_data Philippe Mathieu-Daudé
2025-02-10 17:02 ` Richard Henderson
2025-02-10 17:21 ` Philippe Mathieu-Daudé
2025-03-06 13:16 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2db2d180-b134-4cfe-a5be-b8542aff4bac@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).