From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39457 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8VLd-00089Q-71 for qemu-devel@nongnu.org; Sat, 09 Apr 2011 06:24:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8VLc-0005Ap-5P for qemu-devel@nongnu.org; Sat, 09 Apr 2011 06:24:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8VLb-0005AC-TX for qemu-devel@nongnu.org; Sat, 09 Apr 2011 06:24:56 -0400 From: Amit Shah Date: Sat, 9 Apr 2011 15:54:38 +0530 Message-Id: <2db4951250c8473b5d0b78d24353c45c32b5aa8a.1302344671.git.amit.shah@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] atapi: Drives can be locked without media present List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu list Cc: Kevin Wolf , Juan Quintela , Stefan Hajnoczi , Markus Armbruster , Amit Shah , Paolo Bonzini Drivers are free to lock drives without any media present. Such a condition should not result in an error condition. See Table 341 in MMC-5 spec for details. Signed-off-by: Amit Shah --- hw/ide/core.c | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 7a407fc..8958ff2 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1390,13 +1390,8 @@ static void ide_atapi_cmd(IDEState *s) ide_atapi_cmd_reply(s, 18, max_len); break; case GPCMD_PREVENT_ALLOW_MEDIUM_REMOVAL: - if (bdrv_is_inserted(s->bs)) { - bdrv_set_locked(s->bs, packet[4] & 1); - ide_atapi_cmd_ok(s); - } else { - ide_atapi_cmd_error(s, SENSE_NOT_READY, - ASC_MEDIUM_NOT_PRESENT); - } + bdrv_set_locked(s->bs, packet[4] & 1); + ide_atapi_cmd_ok(s); break; case GPCMD_READ_10: case GPCMD_READ_12: -- 1.7.4.2