qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
	qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, hreitz@redhat.com, kwolf@redhat.com
Subject: Re: [PATCH] iotests/copy-before-write: specify required_fmts
Date: Wed, 6 Jul 2022 19:53:07 +0200	[thread overview]
Message-ID: <2dbc0fa7-5dab-1a95-a050-71b007b2d9bf@redhat.com> (raw)
In-Reply-To: <20220706170834.242277-1-vsementsov@yandex-team.ru>

On 06/07/2022 19.08, Vladimir Sementsov-Ogievskiy wrote:
> Declare that we need copy-before-write filter to avoid failure when
> filter is not whitelisted.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>   tests/qemu-iotests/tests/copy-before-write | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/tests/copy-before-write b/tests/qemu-iotests/tests/copy-before-write
> index 56937b9dff..2ffe092b31 100755
> --- a/tests/qemu-iotests/tests/copy-before-write
> +++ b/tests/qemu-iotests/tests/copy-before-write
> @@ -218,4 +218,5 @@ read failed: Permission denied
>   
>   if __name__ == '__main__':
>       iotests.main(supported_fmts=['qcow2'],
> -                 supported_protocols=['file'])
> +                 supported_protocols=['file'],
> +                 required_fmts=['copy-before-write'])

Thanks, that fixes the issue for me!

Tested-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2022-07-06 17:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 17:08 [PATCH] iotests/copy-before-write: specify required_fmts Vladimir Sementsov-Ogievskiy
2022-07-06 17:53 ` Thomas Huth [this message]
2022-07-12  7:24 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2dbc0fa7-5dab-1a95-a050-71b007b2d9bf@redhat.com \
    --to=thuth@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).