* [PATCH] iotests/copy-before-write: specify required_fmts
@ 2022-07-06 17:08 Vladimir Sementsov-Ogievskiy
2022-07-06 17:53 ` Thomas Huth
2022-07-12 7:24 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2022-07-06 17:08 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, hreitz, kwolf, vsementsov, thuth
Declare that we need copy-before-write filter to avoid failure when
filter is not whitelisted.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
tests/qemu-iotests/tests/copy-before-write | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/tests/copy-before-write b/tests/qemu-iotests/tests/copy-before-write
index 56937b9dff..2ffe092b31 100755
--- a/tests/qemu-iotests/tests/copy-before-write
+++ b/tests/qemu-iotests/tests/copy-before-write
@@ -218,4 +218,5 @@ read failed: Permission denied
if __name__ == '__main__':
iotests.main(supported_fmts=['qcow2'],
- supported_protocols=['file'])
+ supported_protocols=['file'],
+ required_fmts=['copy-before-write'])
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iotests/copy-before-write: specify required_fmts
2022-07-06 17:08 [PATCH] iotests/copy-before-write: specify required_fmts Vladimir Sementsov-Ogievskiy
@ 2022-07-06 17:53 ` Thomas Huth
2022-07-12 7:24 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2022-07-06 17:53 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy, qemu-block; +Cc: qemu-devel, hreitz, kwolf
On 06/07/2022 19.08, Vladimir Sementsov-Ogievskiy wrote:
> Declare that we need copy-before-write filter to avoid failure when
> filter is not whitelisted.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> tests/qemu-iotests/tests/copy-before-write | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/tests/copy-before-write b/tests/qemu-iotests/tests/copy-before-write
> index 56937b9dff..2ffe092b31 100755
> --- a/tests/qemu-iotests/tests/copy-before-write
> +++ b/tests/qemu-iotests/tests/copy-before-write
> @@ -218,4 +218,5 @@ read failed: Permission denied
>
> if __name__ == '__main__':
> iotests.main(supported_fmts=['qcow2'],
> - supported_protocols=['file'])
> + supported_protocols=['file'],
> + required_fmts=['copy-before-write'])
Thanks, that fixes the issue for me!
Tested-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iotests/copy-before-write: specify required_fmts
2022-07-06 17:08 [PATCH] iotests/copy-before-write: specify required_fmts Vladimir Sementsov-Ogievskiy
2022-07-06 17:53 ` Thomas Huth
@ 2022-07-12 7:24 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2022-07-12 7:24 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy, qemu-block; +Cc: qemu-devel, hreitz, kwolf, thuth
On 7/6/22 22:38, Vladimir Sementsov-Ogievskiy wrote:
> Declare that we need copy-before-write filter to avoid failure when
> filter is not whitelisted.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> tests/qemu-iotests/tests/copy-before-write | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/tests/copy-before-write b/tests/qemu-iotests/tests/copy-before-write
> index 56937b9dff..2ffe092b31 100755
> --- a/tests/qemu-iotests/tests/copy-before-write
> +++ b/tests/qemu-iotests/tests/copy-before-write
> @@ -218,4 +218,5 @@ read failed: Permission denied
>
> if __name__ == '__main__':
> iotests.main(supported_fmts=['qcow2'],
> - supported_protocols=['file'])
> + supported_protocols=['file'],
> + required_fmts=['copy-before-write'])
I am going to apply this as a hot fix, trying to re-green the CI.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-12 7:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-06 17:08 [PATCH] iotests/copy-before-write: specify required_fmts Vladimir Sementsov-Ogievskiy
2022-07-06 17:53 ` Thomas Huth
2022-07-12 7:24 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).