From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
Zhuangyanying <ann.zhuangyanying@huawei.com>
Cc: herongguang.he@huawei.com, qemu-devel@nongnu.org,
arei.gonglei@huawei.com, oscar.zhangbo@huawei.com,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] Fix nmi injection failure when vcpu got blocked
Date: Thu, 25 May 2017 16:12:29 +0200 [thread overview]
Message-ID: <2dd7b4c5-de6c-a4c9-0fc3-45d9e3af9405@redhat.com> (raw)
In-Reply-To: <20170524143418.GA7778@potion>
On 24/05/2017 16:34, Radim Krčmář wrote:
>> - if (atomic_read(&vcpu->arch.nmi_queued))
>> + if (vcpu->arch.nmi_pending ||
>> + atomic_read(&vcpu->arch.nmi_queued))
>> return true;
> Hm, I think we've been missing '&& kvm_x86_ops->nmi_allowed(vcpu)'.
>
> The undesired resume if we have suppressed NMI is not making it much
> worse, but wouldn't "kvm_test_request(KVM_REQ_NMI, vcpu)" also work
> here?
Yes, it would be fine (maybe better considering that we have a
KVM_REQ_SMI check just below). Ying, please use it for v2.
Thanks,
Paolo
prev parent reply other threads:[~2017-05-25 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 5:48 [Qemu-devel] [PATCH] Fix nmi injection failure when vcpu got blocked Zhuangyanying
2017-05-24 14:34 ` Radim Krčmář
2017-05-25 6:50 ` Zhuangyanying
2017-05-25 14:12 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dd7b4c5-de6c-a4c9-0fc3-45d9e3af9405@redhat.com \
--to=pbonzini@redhat.com \
--cc=ann.zhuangyanying@huawei.com \
--cc=arei.gonglei@huawei.com \
--cc=herongguang.he@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=oscar.zhangbo@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).