From: "Zoltán Kővágó" <dirty.ice.hu@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] audio: fix buffer-length typo in documentation
Date: Tue, 17 Sep 2019 21:29:34 +0200 [thread overview]
Message-ID: <2de26e7e-1ea9-3fb6-d9b8-fcb397794d82@gmail.com> (raw)
In-Reply-To: <20190911145818.18962-2-stefanha@redhat.com>
On 2019-09-11 16:58, Stefan Hajnoczi wrote:
> Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation")
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> qemu-options.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index bbfd936d29..a4f9f74f52 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -439,7 +439,7 @@ DEF("audiodev", HAS_ARG, QEMU_OPTION_audiodev,
> " in|out.format= sample format to use with fixed settings\n"
> " valid values: s8, s16, s32, u8, u16, u32\n"
> " in|out.voices= number of voices to use\n"
> - " in|out.buffer-len= length of buffer in microseconds\n"
> + " in|out.buffer-length= length of buffer in microseconds\n"
> "-audiodev none,id=id,[,prop[=value][,...]]\n"
> " dummy driver that discards all output\n"
> #ifdef CONFIG_AUDIO_ALSA
> @@ -524,7 +524,7 @@ Valid values are: @code{s8}, @code{s16}, @code{s32}, @code{u8},
> @item in|out.voices=@var{voices}
> Specify the number of @var{voices} to use. Default is 1.
>
> -@item in|out.buffer=@var{usecs}
> +@item in|out.buffer-length=@var{usecs}
> Sets the size of the buffer in microseconds.
>
> @end table
>
Double checking it's indeed "buffer-length" in qapi. Also I spot a
different bug: the alsa documentation qemu-options.hx has "period-len"
but according to qapi it should be "period-length". Care to fix it or
should I submit a different patch?
Regards,
Zoltan
next prev parent reply other threads:[~2019-09-17 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 14:58 [Qemu-devel] [PATCH 0/2] audio: -audiodev documentation tweaks Stefan Hajnoczi
2019-09-11 14:58 ` [Qemu-devel] [PATCH 1/2] audio: fix buffer-length typo in documentation Stefan Hajnoczi
2019-09-17 19:29 ` Zoltán Kővágó [this message]
2019-09-18 9:47 ` Stefan Hajnoczi
2019-09-11 14:58 ` [Qemu-devel] [PATCH 2/2] audio: add -audiodev pa, in|out.latency= to documentation Stefan Hajnoczi
2019-09-17 19:47 ` Zoltán Kővágó
2019-09-18 9:48 ` Stefan Hajnoczi
2019-09-17 15:58 ` [Qemu-devel] [PATCH 0/2] audio: -audiodev documentation tweaks Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2de26e7e-1ea9-3fb6-d9b8-fcb397794d82@gmail.com \
--to=dirty.ice.hu@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).