From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggdCo-00044O-SB for qemu-devel@nongnu.org; Mon, 07 Jan 2019 17:17:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggdCn-00014j-Oa for qemu-devel@nongnu.org; Mon, 07 Jan 2019 17:17:10 -0500 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:46076) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggdCn-000100-Ho for qemu-devel@nongnu.org; Mon, 07 Jan 2019 17:17:09 -0500 Received: by mail-pl1-x644.google.com with SMTP id a14so796079plm.12 for ; Mon, 07 Jan 2019 14:17:08 -0800 (PST) Sender: Richard Henderson References: <154662609174.25797.11037697007951339169.malonedeb@chaenomeles.canonical.com> <154688385484.19401.18084021166417230504.malone@soybean.canonical.com> From: Richard Henderson Message-ID: <2de32a5f-2002-13ef-bded-4ab6cccb20ba@twiddle.net> Date: Tue, 8 Jan 2019 08:17:00 +1000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Bug 1810545] Re: [alpha] Strange exception address reported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , QEMU Developers On 1/8/19 5:00 AM, Peter Maydell wrote: > On Mon, 7 Jan 2019 at 18:10, Peter Maydell wrote: > (re: https://bugs.launchpad.net/bugs/1810545) > >> The problem seems to be that the PC we report for an OPCDEC >> is first selected by gen_invalid()/gen_excp() in >> target/alpha/translate.c, which uses pc_next (ie the insn's >> address plus 4). But that is then handed through to our custom >> PALcode (https://git.qemu.org/?p=qemu-palcode.git;a=blob;f=pal.S;h=1781c4b415700ca3a68af07fdae90ae43e722501;hb=HEAD) which does >> addq p6, 4, p1 // increment past the faulting insn >> resulting in insn + 8. >> >> That is, the palcode and the QEMU code have a disagreement about what >> the (private) API between them is. I'm not sure which side is wrong and >> should be corrected. I think the linux-user code assumes the same thing >> that translate.c is doing, so perhaps the palcode. > > Richard -- any suggestions for which side of this API we should > be changing? Probably the palcode side. I'll take care of it. r~