From: Richard Henderson <richard.henderson@linaro.org>
To: Mostafa Saleh <smostafa@google.com>, qemu-devel@nongnu.org
Cc: jean-philippe@linaro.org, eric.auger@redhat.com,
peter.maydell@linaro.org, qemu-arm@nongnu.org
Subject: Re: [PATCH v4] hw/arm/smmuv3: Add GBPA register
Date: Sat, 11 Feb 2023 13:34:31 -1000 [thread overview]
Message-ID: <2de9abc0-8354-0cc1-dedd-5d4692afc54c@linaro.org> (raw)
In-Reply-To: <20230210221951.1298668-1-smostafa@google.com>
On 2/10/23 12:19, Mostafa Saleh wrote:
> +static bool smmuv3_gbpa_needed(void *opaque)
> +{
> + SMMUv3State *s = opaque;
> +
> + /* Only migrate GBPA if it has different reset value. */
> + if (s->gbpa != SMMU_GBPA_RESET_VAL) {
> + return true;
> + }
> +
> + return false;
Just "return s->gbpa != SMMU_GBPA_RESET_VAL;".
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-02-11 23:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 22:19 [PATCH v4] hw/arm/smmuv3: Add GBPA register Mostafa Saleh
2023-02-11 23:34 ` Richard Henderson [this message]
2023-02-13 16:49 ` Eric Auger
2023-02-11 23:48 ` Richard Henderson
2023-02-12 13:23 ` Mostafa Saleh
2023-02-12 15:18 ` Richard Henderson
2023-02-12 22:20 ` Mostafa Saleh
2023-02-13 10:57 ` Peter Maydell
2023-02-13 19:45 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2de9abc0-8354-0cc1-dedd-5d4692afc54c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=smostafa@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).