From: Paolo Bonzini <pbonzini@redhat.com>
To: "Laurent Vivier" <lvivier@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] scsi-disk: Convert from DPRINTF() macro to trace events
Date: Wed, 19 Dec 2018 22:31:24 +0100 [thread overview]
Message-ID: <2e164218-63ea-4e83-3ca0-9592e68a53fa@redhat.com> (raw)
In-Reply-To: <90581a67-61d5-46e8-1a6c-5e0e342c6546@redhat.com>
On 19/12/18 22:30, Paolo Bonzini wrote:
> On 07/12/18 17:37, Laurent Vivier wrote:
>>> TIL about trace_event_get_state_backends(), I'll use it to clean other
>>> hexdump traces, thanks :)
>> I've copied that from gdbstub.c where there is an hexdump() function
>> using it.
>>
>> I'm going to send a v2 of this patch, because I think it is not needed
>> in this case to pass the function in the parameters.
>
> I think it's better like this, you'd have to free the buffer in the
> caller and that's also ugly.
Nevermind, I diffed v1 and v2 and I see what I mean. I queued v2.
Paolo
next prev parent reply other threads:[~2018-12-19 21:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 13:17 [Qemu-devel] [PATCH 1/2] scsi-disk: Convert from DPRINTF() macro to trace events Laurent Vivier
2018-12-07 13:17 ` [Qemu-devel] [PATCH 2/2] scsi-generic: " Laurent Vivier
2018-12-07 15:38 ` Philippe Mathieu-Daudé
2018-12-07 15:37 ` [Qemu-devel] [PATCH 1/2] scsi-disk: " Philippe Mathieu-Daudé
2018-12-07 16:37 ` Laurent Vivier
2018-12-07 16:46 ` Eric Blake
2018-12-19 21:30 ` Paolo Bonzini
2018-12-19 21:31 ` Paolo Bonzini [this message]
2018-12-07 16:47 ` Eric Blake
2018-12-19 21:29 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e164218-63ea-4e83-3ca0-9592e68a53fa@redhat.com \
--to=pbonzini@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=lvivier@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).