Re: [RFC PATCH] hw/net/can: clean-up unnecessary includes

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 9/12/24 12:23, Pavel Pisa wrote:
> Hello Alex,
> 
> On Monday 09 of December 2024 11:06:35 Alex Bennée wrote:
>> The event_notifier, thread and socket includes look like copy and
>> paste of standard headers. None of the canbus devices use chardev
>> although some relied on chardev to bring in bitops and byte swapping
>> headers. In this case include them directly.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> 
> Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
> 
> Tested on Debian/GNU/Linux for SJA1000 and CTU CAN FD
> 
> QEMU=/home/pi/repo/qemu/qemu-build/qemu-system-x86_64
> 
> $QEMU -enable-kvm -kernel $KERNEL \
>        -m 512M \
>        -initrd ramdisk.cpio \
>        -virtfs local,path=shareddir,security_model=none,mount_tag=shareddir \
>        -vga cirrus \
>        -append "console=ttyS0 \
>        -object can-bus,id=canbus0-bus \
>        -object can-host-socketcan,if=can0,canbus=canbus0-bus,id=canbus0-socketcan \
>        -device kvaser_pci,canbus=canbus0-bus \
>        -device ctucan_pci,canbus0=canbus0-bus,canbus1=canbus0-bus \
>        -nographic
> 
> By the way, I would like to discuse how to update CTU CAN FD a SJA1000
> IRQ handling to allow mapping on FPGA target platform buses from command
> line.

+ Gustavo

> 
> I have some working prototype
> 
>    https://github.com/ppisa/qemu/commits/net-can-ctucanfd-platform/
> 
> but I have some questions how to implement interrupts processing
> (or logic function) correct and acceptable way. I wills tart new
> thread and hope somebody responses and teaches me what is the
> proper solution.
> 
> Best wishes,
> 
>                  Pavel