qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Helge Deller <deller@gmx.de>, Laurent Vivier <laurent@vivier.eu>,
	Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, "Markus F.X.J. Oberhumer" <markus@oberhumer.com>
Subject: Re: [PATCH 2/3] linux-user: Fix the build on systems without MAP_SHARED_VALIDATE
Date: Fri, 11 Aug 2023 00:13:31 +0200	[thread overview]
Message-ID: <2e293848cbacd4b048c32bdcbfd226b510066faa.camel@linux.ibm.com> (raw)
In-Reply-To: <b662c6e4-8905-b6e0-c258-6985a35dd0e7@gmx.de>

On Fri, 2023-08-11 at 00:03 +0200, Helge Deller wrote:
> On 8/10/23 23:51, Ilya Leoshkevich wrote:
> > CentOS 7 does not define MAP_SHARED_VALIDATE. Use a definition
> > provided
> > by the QEMU's copy of linux/mman.h.
> > 
> > Fixes: 4b840f96096d ("linux-user: Populate more bits in
> > mmap_flags_tbl")
> > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> 
> Does it fix the missing MADV_WIPEONFORK as well?
> https://gitlab.com/qemu-project/qemu/-/issues/1824#note_1507837354
> 
> Helge

What a coincidence, that multiple people ran into this on the same day.

This should be fixed by [3/3] of this series.

Best regards,
Ilya


  reply	other threads:[~2023-08-10 22:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 21:51 [PATCH 0/3] Fix the build on CentOS 7 Ilya Leoshkevich
2023-08-10 21:51 ` [PATCH 1/3] linux-user: Fix the build on systems without SOL_ALG Ilya Leoshkevich
2023-08-11 14:11   ` Philippe Mathieu-Daudé
2023-08-10 21:51 ` [PATCH 2/3] linux-user: Fix the build on systems without MAP_SHARED_VALIDATE Ilya Leoshkevich
2023-08-10 22:03   ` Helge Deller
2023-08-10 22:13     ` Ilya Leoshkevich [this message]
2023-08-10 21:51 ` [PATCH 3/3] linux-user: Fix the build on systems without MADV_{KEEP, WIPE}ONFORK Ilya Leoshkevich
2023-08-17 11:03 ` [PATCH 0/3] Fix the build on CentOS 7 Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e293848cbacd4b048c32bdcbfd226b510066faa.camel@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=deller@gmx.de \
    --cc=laurent@vivier.eu \
    --cc=markus@oberhumer.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).