From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: "Víctor Colombo" <victor.colombo@eldorado.org.br>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: clg@kaod.org, david@gibson.dropbear.id.au, groug@kaod.org,
richard.henderson@linaro.org, matheus.ferst@eldorado.org.br,
lucas.araujo@eldorado.org.br, leandro.lupori@eldorado.org.br,
lucas.coutinho@eldorado.org.br
Subject: Re: [PATCH 18/19] target/ppc: Clear fpstatus flags on VSX_CMP
Date: Mon, 5 Sep 2022 15:41:25 -0300 [thread overview]
Message-ID: <2e2cdbcc-bebd-bf58-57e3-39ef7e28a2ae@gmail.com> (raw)
In-Reply-To: <20220901131756.26060-19-victor.colombo@eldorado.org.br>
On 9/1/22 10:17, Víctor Colombo wrote:
> Signed-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>
> ---
What I mentioned in patch 10 also applies to all patches from 11 to 18
it seems. All changes made in patches 09-18 are based on the explanation
gave in patch 08.
The problem with this is that it'll be annoying if/when something goes
wrong. Let's say that the change made in patch 15 caused a side-effect.
Bisect will point it to patch 15, which doesn't have an explanation of
why you made the change, and then one will need to trace it back to the
mailing list to understand it. It's not a given that one will look at
all the recent changes and understand that the logic used in patch 08
are also being used in the subsequent patches.
I don't mind if you just copy/paste the commit message from patch 08 and
just change the instruction name being fixed. What's important is to
provide some context for each individual change.
Thanks,
Daniel
> target/ppc/fpu_helper.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c
> index 5f7f52ab5b..fd3a966371 100644
> --- a/target/ppc/fpu_helper.c
> +++ b/target/ppc/fpu_helper.c
> @@ -2639,6 +2639,8 @@ uint32_t helper_##op(CPUPPCState *env, ppc_vsr_t *xt, \
> int all_true = 1; \
> int all_false = 1; \
> \
> + helper_reset_fpstatus(env); \
> + \
> for (i = 0; i < nels; i++) { \
> if (unlikely(tp##_is_any_nan(xa->fld) || \
> tp##_is_any_nan(xb->fld))) { \
next prev parent reply other threads:[~2022-09-05 18:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 13:17 [PATCH 00/19] Multiple ppc instructions fixes Víctor Colombo
2022-09-01 13:17 ` [PATCH 01/19] target/ppc: Remove extra space from s128 field in ppc_vsr_t Víctor Colombo
2022-09-05 13:17 ` Daniel Henrique Barboza
2022-09-01 13:17 ` [PATCH 02/19] target/ppc: Remove unused xer_* macros Víctor Colombo
2022-09-05 13:58 ` Daniel Henrique Barboza
2022-09-01 13:17 ` [PATCH 03/19] target/ppc: Zero second doubleword in DFP instructions Víctor Colombo
2022-09-05 18:19 ` Daniel Henrique Barboza
2022-09-01 13:17 ` [PATCH 04/19] target/ppc: Set result to QNaN for DENBCD when VXCVI occurs Víctor Colombo
2022-09-05 18:21 ` Daniel Henrique Barboza
2022-09-01 13:17 ` [PATCH 05/19] target/ppc: Zero second doubleword for VSX madd instructions Víctor Colombo
2022-09-05 18:23 ` Daniel Henrique Barboza
2022-09-01 13:17 ` [PATCH 06/19] target/ppc: Set OV32 when OV is set Víctor Colombo
2022-09-05 18:25 ` Daniel Henrique Barboza
2022-09-01 13:17 ` [PATCH 07/19] target/ppc: Zero second doubleword of VSR registers for FPR insns Víctor Colombo
2022-09-05 18:26 ` Daniel Henrique Barboza
2022-09-01 13:17 ` [PATCH 08/19] target/ppc: Clear fpstatus flags on VSX_CVT_INT_TO_FP_VECTOR Víctor Colombo
2022-09-05 18:35 ` Daniel Henrique Barboza
2022-09-01 13:17 ` [PATCH 09/19] target/ppc: Clear fpstatus flags on VSX_CVT_INT_TO_FP Víctor Colombo
2022-09-01 13:17 ` [PATCH 10/19] target/ppc: Clear fpstatus flags on VSX_CVT_FP_TO_FP Víctor Colombo
2022-09-05 18:32 ` Daniel Henrique Barboza
2022-09-01 13:17 ` [PATCH 11/19] target/ppc: Clear fpstatus flags on VSX_CVT_FP_TO_INT_VECTOR Víctor Colombo
2022-09-01 13:17 ` [PATCH 12/19] target/ppc: Clear fpstatus flags on VSX_CVT_FP_TO_INT2 Víctor Colombo
2022-09-01 13:17 ` [PATCH 13/19] target/ppc: Clear fpstatus flags on VSX_CVT_FP_TO_INT Víctor Colombo
2022-09-01 13:17 ` [PATCH 14/19] target/ppc: Clear fpstatus flags on VSX_CVT_FP_TO_FP_HP Víctor Colombo
2022-09-01 13:17 ` [PATCH 15/19] target/ppc: Clear fpstatus flags on VSX_CVT_FP_TO_FP_VECTOR Víctor Colombo
2022-09-01 13:17 ` [PATCH 16/19] target/ppc: Clear fpstatus flags for xscvqpdp Víctor Colombo
2022-09-01 13:17 ` [PATCH 17/19] target/ppc: Clear fpstatus flags for xscvdpsp[n] Víctor Colombo
2022-09-01 13:17 ` [PATCH 18/19] target/ppc: Clear fpstatus flags on VSX_CMP Víctor Colombo
2022-09-05 18:41 ` Daniel Henrique Barboza [this message]
2022-09-05 18:58 ` Víctor Colombo
2022-09-01 13:17 ` [PATCH 19/19] target/ppc: Clear fpstatus flags on VSX_ROUND Víctor Colombo
2022-09-05 18:33 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e2cdbcc-bebd-bf58-57e3-39ef7e28a2ae@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=leandro.lupori@eldorado.org.br \
--cc=lucas.araujo@eldorado.org.br \
--cc=lucas.coutinho@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=victor.colombo@eldorado.org.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).