From: Richard Henderson <richard.henderson@linaro.org>
To: Harsh Prateek Bora <harshpb@linux.ibm.com>, qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org, farosas@suse.de, npiggin@gmail.com,
danielhb413@gmail.com
Subject: Re: [PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers.
Date: Wed, 3 May 2023 11:09:08 +0100 [thread overview]
Message-ID: <2e2db53a-2dd6-46d9-7c0b-f4e3ff4dd1ce@linaro.org> (raw)
In-Reply-To: <20230503093619.2530487-2-harshpb@linux.ibm.com>
On 5/3/23 10:36, Harsh Prateek Bora wrote:
> The bits in cr reg are grouped into eight 4-bit fields represented
> by env->crf[8] and the related calculations should be abstracted to
> keep the calling routines simpler to read. This is a step towards
> cleaning up the related/calling code for better readability.
>
> Signed-off-by: Harsh Prateek Bora<harshpb@linux.ibm.com>
> Reviewed-by: Fabiano Rosas<farosas@suse.de>
> ---
> hw/ppc/spapr_hcall.c | 18 ++----------------
> linux-user/elfload.c | 4 +---
> linux-user/ppc/signal.c | 9 ++-------
> target/ppc/cpu.c | 17 +++++++++++++++++
> target/ppc/cpu.h | 2 ++
> target/ppc/gdbstub.c | 22 ++++------------------
> target/ppc/kvm.c | 13 ++-----------
> target/ppc/ppc-qmp-cmds.c | 6 +-----
> 8 files changed, 31 insertions(+), 60 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-05-03 10:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 9:36 [PATCH v3 0/2] Cleanup ppc cr get/set with helper routines Harsh Prateek Bora
2023-05-03 9:36 ` [PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers Harsh Prateek Bora
2023-05-03 10:09 ` Richard Henderson [this message]
2023-05-03 20:49 ` Daniel Henrique Barboza
2023-05-04 5:33 ` Harsh Prateek Bora
2023-05-03 9:36 ` [PATCH v3 2/2] MAINTAINERS: Adding myself in the list for ppc/spapr Harsh Prateek Bora
2023-05-03 14:31 ` [PATCH v3 0/2] Cleanup ppc cr get/set with helper routines Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e2db53a-2dd6-46d9-7c0b-f4e3ff4dd1ce@linaro.org \
--to=richard.henderson@linaro.org \
--cc=danielhb413@gmail.com \
--cc=farosas@suse.de \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).