From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0850CC3ABC0 for ; Thu, 8 May 2025 07:56:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uCw6f-0004YZ-70; Thu, 08 May 2025 03:55:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uCw6d-0004YL-92 for qemu-devel@nongnu.org; Thu, 08 May 2025 03:55:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uCw6b-0003sA-K6 for qemu-devel@nongnu.org; Thu, 08 May 2025 03:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746690944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OOBMQcHuS726CowzUBIWVhy/mCdvow/YjXZ8UfUxLXc=; b=U9r0KjlekuEFffRK01/w7UpGGkvnQ3B5WCseTInMz9+yJvGFFhk7SMv8o+GFbuET1wTI3N 54FxyTbgfPLmPGR1qgfvb0ogVaFbwq+K2ChpFS3uR5mhy6kEtZYS9Gw2/JZ4t+hzN8U+sO 11qHycyWwbGmoFv2tLH/iFvIqx+Dzis= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-Qh1m7woNOCuvdvJfpEJk-w-1; Thu, 08 May 2025 03:55:43 -0400 X-MC-Unique: Qh1m7woNOCuvdvJfpEJk-w-1 X-Mimecast-MFC-AGG-ID: Qh1m7woNOCuvdvJfpEJk-w_1746690942 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39c1b1c0969so425418f8f.1 for ; Thu, 08 May 2025 00:55:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746690942; x=1747295742; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OOBMQcHuS726CowzUBIWVhy/mCdvow/YjXZ8UfUxLXc=; b=bU9qOLworbJcmpNqG4ph3ht2imi7ZQJkLg+p1zYZkkVfTl5s4d4bJtRduG/Qa4KGEc yho6+HVf+0Iiu4QoT4aXpcx6tCgZ4gLCl3wZGYQP5K/7ysDbDVO1h1QeJrTf4XP+uCN8 opyW3LyruUgyhWMihD0DwS4qVxLokJbuwHSI6GnVs5VY6yFoADy8L+Jf2QcZsdLBw4uK t7qFOM6lhxZGXLRrh9fL0g5lA62Ug1wX7xqGaMrsuWJDDCMnuSTjv7kAuc91lAVobg9F UEDMgBUytmb3otMuYurotq6H8P8xaOdl5BTrP7XjBFwMdsWKoUji5gTvibLEwlUUHa62 EQOA== X-Forwarded-Encrypted: i=1; AJvYcCXQwniZNBECCEc5JVG9nkF6GABHi+CRB1PT5BBr7CM6R4cmMQgdAQ/ectOvw7tThzXIWKyYApMuNnQu@nongnu.org X-Gm-Message-State: AOJu0Ywtg/eewOXhK9GKYZaptNqe1V89qMORMu99uUZTj0E2Wbtqlv0M TI61sAgqqW2mT23b0VAWqquNeuWfwPMG0JsWqxV65IgM6H7Rg7WIjusJ81CQfLaEeCESqsEYoHk l4ZAwcZBBGVRJRb63j1lFsfVIAA1CYHXdjgeVyM11uQZ/r9Xp+OlY X-Gm-Gg: ASbGnct9zWvvbBrn0rICXnTSKvF8wPyFDKWFvtRWWo1PZUNbN1HgRkhIPdFhuFVzXLJ vcbv7816fveRgHtR041cOnGUZxksXVvhxaEeSwRsnV/oaI2o1028kt/M33knGyOvsU3zM6/YEac UywcKU8pJdHmXlQnZdmoQLj9IlCmTvl64IIqQhgiCtT29Qg+grX3qNGHR1sySwCad3VsyXNKIpC 0Nds0/V5hV3roCrznB/MwVhpW9OveHP/1hsFu92TbVIxs6jrpbEBRPqsMt1QNjfIjBLwY8Ljihj t87i9IKohffK+XWJ1EUNwjADcIxgxfjebLonS0CZc7sG/yeWsrbi X-Received: by 2002:a05:6000:40de:b0:3a0:aeba:23b1 with SMTP id ffacd0b85a97d-3a0b4a6f746mr5147452f8f.49.1746690942295; Thu, 08 May 2025 00:55:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE774Wi3vl3AC4YkO2o6/kAwi20xYE0NLkBXFM7MtnDFMbZMRZLJCsWERDKk/war6/CxY/NJg== X-Received: by 2002:a05:6000:40de:b0:3a0:aeba:23b1 with SMTP id ffacd0b85a97d-3a0b4a6f746mr5147421f8f.49.1746690941931; Thu, 08 May 2025 00:55:41 -0700 (PDT) Received: from [192.168.0.7] (ltea-047-064-115-173.pools.arcor-ip.net. [47.64.115.173]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099ae0c31sm19622689f8f.10.2025.05.08.00.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 00:55:41 -0700 (PDT) Message-ID: <2e2f4b39-d7f1-4817-947f-106558c1621c@redhat.com> Date: Thu, 8 May 2025 09:55:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/19] hw/i386/pc: Remove pc_compat_2_7[] array To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Laurent Vivier , Igor Mammedov , Huacai Chen , Amit Shah , Marcel Apfelbaum , Sergio Lopez , Ani Sinha , Paolo Bonzini , Eduardo Habkost , Jiaxun Yang , Jason Wang , Richard Henderson , Yanan Wang , Gerd Hoffmann , =?UTF-8?Q?Cl=C3=A9ment_Mathieu--Drif?= , Zhao Liu , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Yi Liu , "Michael S. Tsirkin" , Mark Cave-Ayland References: <20250502185652.67370-1-philmd@linaro.org> <20250502185652.67370-13-philmd@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250502185652.67370-13-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.414, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 02/05/2025 20.56, Philippe Mathieu-Daudé wrote: > The pc_compat_2_7[] array was only used by the pc-q35-2.7 > and pc-i440fx-2.7 machines, which got removed. Remove it. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Mark Cave-Ayland > --- > include/hw/i386/pc.h | 3 --- > hw/i386/pc.c | 10 ---------- > 2 files changed, 13 deletions(-) > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > index 4fb2033bc54..319ec82f709 100644 > --- a/include/hw/i386/pc.h > +++ b/include/hw/i386/pc.h > @@ -289,9 +289,6 @@ extern const size_t pc_compat_2_9_len; > extern GlobalProperty pc_compat_2_8[]; > extern const size_t pc_compat_2_8_len; > > -extern GlobalProperty pc_compat_2_7[]; > -extern const size_t pc_compat_2_7_len; > - > #define DEFINE_PC_MACHINE(suffix, namestr, initfn, optsfn) \ > static void pc_machine_##suffix##_class_init(ObjectClass *oc, \ > const void *data) \ > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 7573b880905..ee7095c89a8 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -241,16 +241,6 @@ GlobalProperty pc_compat_2_8[] = { > }; > const size_t pc_compat_2_8_len = G_N_ELEMENTS(pc_compat_2_8); > > -GlobalProperty pc_compat_2_7[] = { > - { TYPE_X86_CPU, "l3-cache", "off" }, > - { TYPE_X86_CPU, "full-cpuid-auto-level", "off" }, > - { "Opteron_G3" "-" TYPE_X86_CPU, "family", "15" }, > - { "Opteron_G3" "-" TYPE_X86_CPU, "model", "6" }, > - { "Opteron_G3" "-" TYPE_X86_CPU, "stepping", "1" }, > - { "isa-pcspk", "migrate", "off" }, > -}; > -const size_t pc_compat_2_7_len = G_N_ELEMENTS(pc_compat_2_7); I'd really appreciate if you could provide clean-up patches for TYPE_X86_CPU, too. Otherwise I'm pretty sure we'll forget that there is some clean up possibility here. Anyway, for this patch here: Reviewed-by: Thomas Huth