From: Thomas Huth <thuth@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
armbru@redhat.com, f4bug@amsat.org
Subject: Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds
Date: Sat, 19 Aug 2017 09:37:06 +0200 [thread overview]
Message-ID: <2e4024b0-ec9d-151a-28b0-01c50471570b@redhat.com> (raw)
In-Reply-To: <20170818222313.13391-1-eblake@redhat.com>
On 19.08.2017 00:23, Eric Blake wrote:
> We already have several files that knowingly require assert()
> to work. While we do NOT want to encourage the use of
> 'assert(side-effects)' (that is a bad practice that prevents
> copy-and-paste of code to other projects that CAN disable
> assertions; plus it costs unnecessary reviewer mental cycles
> to remember our project policy on crippling asserts), we DO
> want to send a message that anyone that disables assertions
> has to tweak code in order to compile, making it obvious that
> we are not going to support their efforts.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> First mentioned as an idea here:
> http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg06084.html
> but I'm titling this RFC as I'm not 100% convinced we want to make
> it a project-wide, rather than a per-file decision.
I think we should make this project-wide. Otherwise we will have the
discussion again and again whether it is ok to compile with NDEBUG or not.
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2017-08-19 7:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 22:23 [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds Eric Blake
2017-08-18 22:57 ` Philippe Mathieu-Daudé
2017-08-19 7:37 ` Thomas Huth [this message]
2017-08-21 9:31 ` Markus Armbruster
2017-08-21 10:08 ` Peter Maydell
2017-09-05 19:45 ` Eric Blake
2017-08-22 11:19 ` Halil Pasic
2017-08-23 19:21 ` Eric Blake
2017-08-24 7:51 ` Markus Armbruster
2017-09-05 19:50 ` Eric Blake
2017-09-06 5:26 ` Thomas Huth
2017-09-11 10:30 ` Paolo Bonzini
2017-09-11 10:40 ` Peter Maydell
2017-09-06 11:35 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e4024b0-ec9d-151a-28b0-01c50471570b@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).