Re: [Qemu-devel] [PATCH v5 10/28] target/arm: convert conversion helpers to fpst/ahp_flag

[Richard Henderson <richard.henderson@linaro.org>]

On 05/15/2018 03:08 AM, Peter Maydell wrote:
> On 14 May 2018 at 23:12, Richard Henderson <richard.henderson@linaro.org> wrote:
>> From: Alex Bennée <alex.bennee@linaro.org>
>>
>> Instead of passing env and leaving it up to the helper to get the
>> right fpstatus we pass it explicitly. There was already a get_fpstatus
>> helper for neon for the 32 bit code. We also add an get_ahp_flag() for
>> passing the state of the alternative FP16 format flag. This leaves
>> scope for later tracking the AHP state in translation flags.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> ---
>> v4
>>   - remove neon_fcvt_*; they are now identical to vfp_fcvt_*.
>>   - add flags to vfp_fcvt_* helper decls.
>>   - add some missing tcg_temp_free_*.
>> v5
>>   - always use get_fpstatus_ptr(false) for FZ, since FZ16 is
>>     supposed to be supressed.
>> ---
> 
>> @@ -9053,12 +9066,17 @@ static void handle_2misc_narrow(DisasContext *s, bool scalar,
>>              } else {
>>                  TCGv_i32 tcg_lo = tcg_temp_new_i32();
>>                  TCGv_i32 tcg_hi = tcg_temp_new_i32();
>> +                TCGv_ptr fpst = get_fpstatus_ptr(true);
> 
> Still the wrong fpstatus here...

Bah.  Got em now.  Thanks.


r~