From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5ZJc-0004Qh-OH for qemu-devel@nongnu.org; Wed, 25 May 2016 09:57:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5ZJX-0003n8-Rs for qemu-devel@nongnu.org; Wed, 25 May 2016 09:57:39 -0400 References: <1463470536-8981-1-git-send-email-famz@redhat.com> <1463470536-8981-26-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <2e51a35b-42b1-4aa5-86fd-d5455985f155@redhat.com> Date: Wed, 25 May 2016 15:57:22 +0200 MIME-Version: 1.0 In-Reply-To: <1463470536-8981-26-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WbJIONtdHA69X6NgLkGvaOf1rVaWKB0FQ" Subject: Re: [Qemu-devel] [PATCH v5 25/27] tests: Use null-co:// instead of /dev/null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Markus Armbruster , Eric Blake , John Snow , qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, den@openvz.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WbJIONtdHA69X6NgLkGvaOf1rVaWKB0FQ From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Markus Armbruster , Eric Blake , John Snow , qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, den@openvz.org, stefanha@redhat.com Message-ID: <2e51a35b-42b1-4aa5-86fd-d5455985f155@redhat.com> Subject: Re: [PATCH v5 25/27] tests: Use null-co:// instead of /dev/null References: <1463470536-8981-1-git-send-email-famz@redhat.com> <1463470536-8981-26-git-send-email-famz@redhat.com> In-Reply-To: <1463470536-8981-26-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 17.05.2016 09:35, Fam Zheng wrote: > With image locking, opening /dev/null can fail when multiple tests run > in parallel (make -j2, for example). Use null-co:// as the null protoco= l > doesn't do image locking. >=20 > While it's arguable we could special-case /dev/null, /dev/zero, > /dev/urandom etc in raw-posix driver, it is not really necessary becaus= e > user can always specify lock-mode=3Doff when it is appropriate. So let'= s > write sensible testing code too. >=20 > Signed-off-by: Fam Zheng > --- > tests/drive_del-test.c | 2 +- > tests/nvme-test.c | 2 +- > tests/usb-hcd-uhci-test.c | 2 +- > tests/usb-hcd-xhci-test.c | 2 +- > tests/virtio-blk-test.c | 2 +- > tests/virtio-scsi-test.c | 4 ++-- > 6 files changed, 7 insertions(+), 7 deletions(-) I prefer a plain driver=3Dnull-co instead of file=3Dnull-co://,format=3Dr= aw, but whatever floats your boat. Reviewed-by: Max Reitz --WbJIONtdHA69X6NgLkGvaOf1rVaWKB0FQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXRa9CAAoJEDuxQgLoOKyt34UH/2gEDuvedliMmEvP0zDQy6uY +Uw4VhBAAoF2BIEr2QXdyjunaefZ+ZEnY+nfXriHZUwtIYxfK0PQEHanfEfmxuUp soxyyOsEBxIuT+kTxaMEpT4fNHHxv4zFsamBxdvZQkp0wPfQf31ojWBPg3ozAWXv JLpDY7YGEr52gOvutXRazMJeD/So+SbJHO2C59Oid2C3JD4HTcScezsJh9HvHFK+ Fat2OJ2CJBSgAPUi1BftNFlwwLMN1ASHJhd9LAaF6w7Lp0m459nGECHKk3gKKjrP apfvZkwoIuQ/HHWDpAdaeHDohDa7XfnFoeTD3aFwYZvRQPrl/GOVUzryTj8GYz0= =dDAl -----END PGP SIGNATURE----- --WbJIONtdHA69X6NgLkGvaOf1rVaWKB0FQ--