qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Thomas Huth" <thuth@redhat.com>,
	qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] travis.yml: Use clang++ in the Clang tests
Date: Mon, 18 May 2020 11:15:58 +0200	[thread overview]
Message-ID: <2e571780-e8d6-406f-0475-afa43bcb0815@redhat.com> (raw)
In-Reply-To: <20200518083316.25065-1-thuth@redhat.com>

On 5/18/20 10:33 AM, Thomas Huth wrote:
> Our configure script does not look for clang++ automatically, so we
> should use --cxx=clang++ to make sure that we test our C++ code with
> Clang, too. And while we're at it, also use --host-cc=clang here
> to avoid that we use the normal "cc" as host C compiler.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   .travis.yml | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 1ec8a7b465..564be50a3c 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -205,14 +205,15 @@ jobs:
>       # Test with Clang for compile portability (Travis uses clang-5.0)
>       - name: "Clang (user)"
>         env:
> -        - CONFIG="--disable-system"
> +        - CONFIG="--disable-system --host-cc=clang --cxx=clang++"
>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
>         compiler: clang
>   
>   
>       - name: "Clang (main-softmmu)"
>         env:
> -        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
> +        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}
> +                  --host-cc=clang --cxx=clang++"
>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
>         compiler: clang
>         before_script:
> @@ -222,7 +223,8 @@ jobs:
>   
>       - name: "Clang (other-softmmu)"
>         env:
> -        - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
> +        - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}
> +                  --host-cc=clang --cxx=clang++"
>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
>         compiler: clang
>   
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



  parent reply	other threads:[~2020-05-18  9:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18  8:33 [PATCH] travis.yml: Use clang++ in the Clang tests Thomas Huth
2020-05-18  8:33 ` Thomas Huth
2020-05-18  9:15 ` Philippe Mathieu-Daudé [this message]
2020-05-18 12:44 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e571780-e8d6-406f-0475-afa43bcb0815@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).