From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] osdep.h: pull in sys/sysmacros.h for major/minor/makedev
Date: Mon, 13 Mar 2017 13:31:38 -0500 [thread overview]
Message-ID: <2e5c8c2d-35a7-a26a-bd80-379479125d9c@redhat.com> (raw)
In-Reply-To: <CAFEAcA9CX2uVsK0qOM0K+y9JxQ+Nk=GMUp5M4xrMsqGg=fE4nQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]
On 02/15/2017 06:50 AM, Peter Maydell wrote:
> On 15 February 2017 at 03:02, Mike Frysinger <vapier@gentoo.org> wrote:
>> On 10 Feb 2017 09:04, Peter Maydell wrote:
>>> I still think that it's a shame that glibc is breaking
>>> compatibility with where these macros have always been
>>> kept on every OS that's implemented them back to 2BSD...
>>
>> i don't think that characterization is accurate. if it were,
>> autoconf wouldn't have a AC_HEADER_MAJOR helper.
>
> Hmm, Googling suggests that Solaris (and perhaps
> other SysV Unixes) put them in mkdev.h.
> That doesn't explain why glibc is taking yet a third
> approach here rather than using either of the two
> previously used choices...
Whether or not you think glibc broke things, the fact remains that the
build is broken on current Fedora rawhide if we don't apply either this
or the other proposed patch (the one by Christopher Covington, which
I've now pinged)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-03-13 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 6:12 [Qemu-devel] [PATCH] osdep.h: pull in sys/sysmacros.h for major/minor/makedev Mike Frysinger
2017-02-10 6:15 ` no-reply
2017-02-10 9:04 ` Peter Maydell
2017-02-15 3:02 ` Mike Frysinger
2017-02-15 12:50 ` Peter Maydell
2017-03-13 18:31 ` Eric Blake [this message]
2017-03-13 18:41 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e5c8c2d-35a7-a26a-bd80-379479125d9c@redhat.com \
--to=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).