Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700

["Cédric Le Goater" <clg@kaod.org>]

Hell Jamin,

On 9/18/25 05:13, Jamin Lin wrote:
> v1:
>   1. Add PCIe PHY, CFG, and MMIO window support for AST2600.
>      Note: Only supports RC_H.
>   2. Add PCIe PHY, CFG, and MMIO window support for AST2700.
>      Note: Supports 3 RCs.
> 
> v2:
>    1. Introduce a new root port device.
>    2. For AST2600 RC_H, add the root device at 80:00.0 and a root port at 80.08.0
>       to match the real hardware topology, allowing users to attach PCIe devices
>       at the root port.
>    3. For AST2700, add a root port at 00.00.0 for each PCIe root complex to match
>       the real hardware topology, allowing users to attach PCIe devices at the
>       root port.
> 
> v3:
>    1. Fix review issues.
>    2. update functional test for the e1000e network card.
>    3. update license header
>    4. Adding "Based on previous work from Cedric Le Goater, with Jamin's summary
>       implementation.

v3 looks good. I only had a few comments on memory allocation
(g_autofree and MMIO alias regions) and on functional tests.

v4 should be the last.


> 
> Dependencies
> 
> QEMU version:
> https://github.com/qemu/qemu/commit/f0007b7f03e2d7fc33e71c3a582f2364c51a226b
> 
> This patch series depends on the following patch series:
> 1. hw/arm/aspeed Move ast2700-evb alias to ast2700a1-evb
> https://patchwork.kernel.org/project/qemu-devel/patch/20250902062550.3797040-1-jamin_lin@aspeedtech.com/
> 2. tests/functional/arm: Update test images for ASPEED chips
> https://patchwork.kernel.org/project/qemu-devel/cover/20250904100556.1729604-1-kane_chen@aspeedtech.com/
> 3. tests/functional/arm: Add OTP functional test
> https://patchwork.kernel.org/project/qemu-devel/cover/20250917035917.4141723-1-kane_chen@aspeedtech.com/


There changes are in aspeed-next. You could use it as a reference
in the cover letter.


Thanks,

C.