From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-img: Improve commit invalid base message
Date: Fri, 2 Dec 2016 00:38:49 +0100 [thread overview]
Message-ID: <2e638f2b-cc8c-643d-66e7-3d92ebb44b13@redhat.com> (raw)
In-Reply-To: <5a6a7661-e8aa-bb46-5e4c-d261985da9a8@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
On 01.12.2016 03:36, Eric Blake wrote:
> On 11/30/2016 08:05 PM, Max Reitz wrote:
>> When trying to invoke qemu-img commit with a base image file name that
>> is not part of the top image's backing chain, the user receives a rather
>> plain "Base not found" error message. This is not really helpful because
>> it does not explain what "not found" means, potentially leaving the user
>> wondering why qemu cannot find a file despite it clearly existing in the
>> file system.
>>
>> Improve the error message by clarifying that "not found" means "not
>> found in the top image's backing chain".
>>
>> Reported-by: Ala Hino <ahino@redhat.com>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> Reported in: https://bugzilla.redhat.com/show_bug.cgi?id=1390991
>> ---
>> qemu-img.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Safe for 2.8, if the block maintainers agree.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks!
I agree that it's safe, but we're at a point where only critical things
should go into the release. Getting this into 2.9 will be sufficient.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2016-12-01 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 2:05 [Qemu-devel] [PATCH] qemu-img: Improve commit invalid base message Max Reitz
2016-12-01 2:36 ` Eric Blake
2016-12-01 23:38 ` Max Reitz [this message]
2017-01-16 17:16 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e638f2b-cc8c-643d-66e7-3d92ebb44b13@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).