From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCawO-00016V-2A for qemu-devel@nongnu.org; Thu, 01 Dec 2016 18:39:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCawN-0003pn-Be for qemu-devel@nongnu.org; Thu, 01 Dec 2016 18:39:00 -0500 References: <20161201020508.24417-1-mreitz@redhat.com> <5a6a7661-e8aa-bb46-5e4c-d261985da9a8@redhat.com> From: Max Reitz Message-ID: <2e638f2b-cc8c-643d-66e7-3d92ebb44b13@redhat.com> Date: Fri, 2 Dec 2016 00:38:49 +0100 MIME-Version: 1.0 In-Reply-To: <5a6a7661-e8aa-bb46-5e4c-d261985da9a8@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="58p45ebninn3Neitvg8VoA2IG3jLW0tTE" Subject: Re: [Qemu-devel] [PATCH] qemu-img: Improve commit invalid base message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --58p45ebninn3Neitvg8VoA2IG3jLW0tTE From: Max Reitz To: Eric Blake , qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org Message-ID: <2e638f2b-cc8c-643d-66e7-3d92ebb44b13@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu-img: Improve commit invalid base message References: <20161201020508.24417-1-mreitz@redhat.com> <5a6a7661-e8aa-bb46-5e4c-d261985da9a8@redhat.com> In-Reply-To: <5a6a7661-e8aa-bb46-5e4c-d261985da9a8@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01.12.2016 03:36, Eric Blake wrote: > On 11/30/2016 08:05 PM, Max Reitz wrote: >> When trying to invoke qemu-img commit with a base image file name that= >> is not part of the top image's backing chain, the user receives a rath= er >> plain "Base not found" error message. This is not really helpful becau= se >> it does not explain what "not found" means, potentially leaving the us= er >> wondering why qemu cannot find a file despite it clearly existing in t= he >> file system. >> >> Improve the error message by clarifying that "not found" means "not >> found in the top image's backing chain". >> >> Reported-by: Ala Hino >> Signed-off-by: Max Reitz >> --- >> Reported in: https://bugzilla.redhat.com/show_bug.cgi?id=3D1390991 >> --- >> qemu-img.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > Safe for 2.8, if the block maintainers agree. >=20 > Reviewed-by: Eric Blake Thanks! I agree that it's safe, but we're at a point where only critical things should go into the release. Getting this into 2.9 will be sufficient. Max --58p45ebninn3Neitvg8VoA2IG3jLW0tTE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFGBAEBCAAwFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlhAtIkSHG1yZWl0ekBy ZWRoYXQuY29tAAoJEPQH2wBh1c9Ad74H/38KLAWuKizkAT5q0Xo2TBeXzJEZeHSn Sy47QhNIyBz6dQxeTpRWy0fSLYY5eNz1BYkVkmEkt3AQAsbNzlas6t3GU6MVsa5E Eh1T6QNQjsd4SD3f6B9b6R+VZwlJ10MXHKEz8jsUpZrEuUcLoLunPAUHH+GiJ14P qnzvnbNZSQsbVWUC8rK3SzXthgyHLJRcKtqvTgqYRMhFzDLd8P5CiKm/ZEAJ5RjQ sgQvQW9+z6dBlDZZJXBlzYw6AJwRk88vcejOQimr3jkXz6TPmM/gCUNeg7GDtLw8 iyEIQzkVCbV1bjBGpmVNWiF0RWGOJhpe7Fm9y0FUvJeKwbo6W+oOq0k= =iq+n -----END PGP SIGNATURE----- --58p45ebninn3Neitvg8VoA2IG3jLW0tTE--