From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
Peter Xu <peterx@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
qemu-trivial@nongnu.org,
"Dr. David Alan Gilbert" <dave@treblig.org>,
Richard Henderson <richard.henderson@linaro.org>,
Laurent Vivier <laurent@vivier.eu>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 1/3] cpu-target: Include missing 'exec/memory.h' header
Date: Fri, 9 Feb 2024 17:31:42 +0100 [thread overview]
Message-ID: <2e670901-685e-4ecb-80f7-fdaf18749b10@linaro.org> (raw)
In-Reply-To: <CAFEAcA82_L4tJTFB2OP795Yad1bTzgK0MzQNY41nGz5LEbkC6g@mail.gmail.com>
On 9/2/24 17:01, Peter Maydell wrote:
> On Fri, 9 Feb 2024 at 15:01, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>> Include "exec/memory.h" in order to avoid:
>>
>> cpu-target.c:201:50: error: use of undeclared identifier 'TYPE_MEMORY_REGION'
>> DEFINE_PROP_LINK("memory", CPUState, memory, TYPE_MEMORY_REGION,
>> ^
>
> Given that we don't actually see this error, presumably
> we're implicitly dragging it in via some other include?
It is pulled in by the exec/cpu-all.h header which I'm trying to
sanitize (along with others). I'll add a note about this.
> Anyway, better to be explicit than implicit, so
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Thanks!
next prev parent reply other threads:[~2024-02-09 16:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 15:00 [PATCH 0/3] system/memory: Trivial fixes Philippe Mathieu-Daudé
2024-02-09 15:00 ` [PATCH 1/3] cpu-target: Include missing 'exec/memory.h' header Philippe Mathieu-Daudé
2024-02-09 16:01 ` Peter Maydell
2024-02-09 16:31 ` Philippe Mathieu-Daudé [this message]
2024-02-09 15:00 ` [PATCH 2/3] monitor/target: " Philippe Mathieu-Daudé
2024-02-09 16:01 ` Peter Maydell
2024-02-09 15:00 ` [PATCH 3/3] system/physmem: Assign global system I/O Memory to machine Philippe Mathieu-Daudé
2024-02-09 16:06 ` Peter Maydell
2024-02-09 16:41 ` Philippe Mathieu-Daudé
2024-02-09 21:33 ` [PATCH 0/3] system/memory: Trivial fixes Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e670901-685e-4ecb-80f7-fdaf18749b10@linaro.org \
--to=philmd@linaro.org \
--cc=dave@treblig.org \
--cc=david@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).