From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1315BC48297 for ; Fri, 9 Feb 2024 16:32:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYTn5-0005d8-71; Fri, 09 Feb 2024 11:31:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYTn3-0005cj-Cl for qemu-devel@nongnu.org; Fri, 09 Feb 2024 11:31:49 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYTn1-0004O0-UC for qemu-devel@nongnu.org; Fri, 09 Feb 2024 11:31:49 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40fd72f7125so9699255e9.1 for ; Fri, 09 Feb 2024 08:31:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707496305; x=1708101105; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CcOcXq/WM7lnYX2SnxhIY5A52vsg0Yfq3GzXmJ1TkLA=; b=QUD7lC9WJewhSgJcya+8opp8TNOrorcWYxq3sOuU9t88/T+9G7cPHse4TW5rpwLlrV Ul9k3b/zGwu4od4Crxx11dFtzLFpvZgqSZ7AmVIaWHQ7UjPCWE57FrmmqShpr4EnBWn6 ZLZcgr/tHuB/l32qKlcjDswJd/zAA4FJz+nbm80AnbkRyLPqqqXM2TTVj+9kNOscq0d4 frnNxFli5Cee41IzkyZ90Mln17ma6tk4PkExZjf/pn+NSkfsvxxxXgxdvJjBk0pPvb5A ZIgzwtcWTWpQN6goODYoMGM0QAvGhFrslWKOwgJrVrBG9npXqm5w64NYQUTgVYk/O7Is qEWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707496305; x=1708101105; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CcOcXq/WM7lnYX2SnxhIY5A52vsg0Yfq3GzXmJ1TkLA=; b=KePFJTmbAJMy2ARatj6XiHyyO86eejeG6Doi63WAFwNZXOtoP7fNPoDGza8JTM8KMR Q4tx/PkP7wBh60coX3tvKlXR4KRS3Ik1pEB8wFyxh8p2K6WVZlrNLgBpNWvCIWAebVdP HEJjuVgfuGbu2WAwWdGkH4XM7/j8OSHDS7HtjOAA4ofnU0gEcBwZ1cdqgWYB2eYYHqGS ri+JLlqCxj4hjv1M0paD7ecAi/PdKATuVcK6KaSkwq99Re5zbg3BC4vZn1acAzuO5gM7 D+PVZS9EZGJQixVokZxuT+ZfEsOfKXtHDjsMGgwnXpeNrzN8Ob3boB7iDhW3aKHesnQC P3Iw== X-Gm-Message-State: AOJu0YxRRij+FBGLSvIPYfwhV1CYHRLlpzFQSbX0ZSsI5nNxr7fbLWxt zK7RFqG2/EpN8YN4VQygfNYWZpFi3dXbHv2rS4hG9jT/RtIpKIDA0LIUMcaeMvc= X-Google-Smtp-Source: AGHT+IEFkpcY93yzEoAjdgBIvQI6/gEdD42oofaREwLASChZ8LpbQaX68XOvSmnjoAKFqZ3rECBL9g== X-Received: by 2002:a05:600c:3ba6:b0:410:7635:4087 with SMTP id n38-20020a05600c3ba600b0041076354087mr1483779wms.6.1707496304854; Fri, 09 Feb 2024 08:31:44 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWL0ajCgO5Hr4K+JcTXSilEBtthsf0Lj28KtJ0p+rrOAeqc/tUIpEqab3VeRRrBBRjdCL26vkG9idfp2ydbvLmBZcUBHY9uIrLAcVvdFRdEJE1fv//TTWpRqoLSn32K4zCJLAloChkJGQh2DdfglX/3kT1ouRiXa9uLvEKNdtO3btWQ6RR74I3NcXV3APggkYPA34H3ENtbG4tFYGkCwxr6aoPw4NGXCzPRTqQcYJ0fZGbdYE81VTfnBq2Qio/xi8XS5wgA+UF+DVze7X3hzCkoTOzUIg== Received: from [192.168.69.100] ([176.176.147.207]) by smtp.gmail.com with ESMTPSA id jr6-20020a05600c560600b0041079d336c7sm1078728wmb.39.2024.02.09.08.31.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Feb 2024 08:31:44 -0800 (PST) Message-ID: <2e670901-685e-4ecb-80f7-fdaf18749b10@linaro.org> Date: Fri, 9 Feb 2024 17:31:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] cpu-target: Include missing 'exec/memory.h' header Content-Language: en-US To: Peter Maydell Cc: qemu-devel@nongnu.org, Michael Tokarev , Peter Xu , Paolo Bonzini , qemu-trivial@nongnu.org, "Dr. David Alan Gilbert" , Richard Henderson , Laurent Vivier , David Hildenbrand References: <20240209150039.22211-1-philmd@linaro.org> <20240209150039.22211-2-philmd@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 9/2/24 17:01, Peter Maydell wrote: > On Fri, 9 Feb 2024 at 15:01, Philippe Mathieu-Daudé wrote: >> >> Include "exec/memory.h" in order to avoid: >> >> cpu-target.c:201:50: error: use of undeclared identifier 'TYPE_MEMORY_REGION' >> DEFINE_PROP_LINK("memory", CPUState, memory, TYPE_MEMORY_REGION, >> ^ > > Given that we don't actually see this error, presumably > we're implicitly dragging it in via some other include? It is pulled in by the exec/cpu-all.h header which I'm trying to sanitize (along with others). I'll add a note about this. > Anyway, better to be explicit than implicit, so > > Reviewed-by: Peter Maydell Thanks!