From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
David Edmondson <david.edmondson@oracle.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v2 1/2] qemu-img: Add --target-is-zero to convert
Date: Mon, 3 Feb 2020 13:00:05 -0600 [thread overview]
Message-ID: <2e7777b6-5ae0-973c-1040-dae6def3925c@redhat.com> (raw)
In-Reply-To: <4b23f9d9-efe4-000d-0d68-66028ad3d2f3@virtuozzo.com>
On 2/3/20 12:20 PM, Vladimir Sementsov-Ogievskiy wrote:
> 24.01.2020 13:34, David Edmondson wrote:
>> In many cases the target of a convert operation is a newly provisioned
>> target that the user knows is blank (filled with zeroes). In this
>> situation there is no requirement for qemu-img to wastefully zero out
>> the entire device.
>>
>> Add a new option, --target-is-zero, allowing the user to indicate that
>> an existing target device is already zero filled.
>
> Hi! qemu-img.c part looks OK for me, but other doesn't apply on master now.
Correct. Patch 2/2 is now obsolete and no longer necessary, and patch 1
needs some tweaks now that we don't have qemu-img.texi.
>
> I like this thing, and I'd like to make similar option for backup job.
My followup patches to add an all-zero bit to qcow2 are also useful in
this regard.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-02-03 19:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 10:34 [PATCH v2 0/2] qemu-img: Add --target-is-zero to indicate that a target is blank David Edmondson
2020-01-24 10:34 ` [PATCH v2 1/2] qemu-img: Add --target-is-zero to convert David Edmondson
2020-01-27 22:39 ` Eric Blake
2020-01-28 7:46 ` David Edmondson
2020-02-03 18:20 ` Vladimir Sementsov-Ogievskiy
2020-02-03 19:00 ` Eric Blake [this message]
2020-02-04 9:54 ` David Edmondson
2020-01-24 10:34 ` [PATCH v2 2/2] doc: Use @code rather than @var for options David Edmondson
2020-01-27 19:31 ` Eric Blake
2020-01-28 7:39 ` David Edmondson
2020-01-28 9:10 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e7777b6-5ae0-973c-1040-dae6def3925c@redhat.com \
--to=eblake@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).