Re: [PATCH v4 00/27] Implementing a MSHV (Microsoft Hypervisor) accelerator

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 2/10/25 10:41, Daniel P. Berrangé wrote:
> On Thu, Oct 02, 2025 at 10:30:56AM +0200, Philippe Mathieu-Daudé wrote:
>> Hi Magnus,
>>
>> On 16/9/25 18:48, Magnus Kulke wrote:
>>> Hello all,
>>>
>>> This is the fourth revision of a patch set implementing an accelerator
>>> for the MSHV kernel driver, exposing HyperV to Linux "Dom0" hosts in
>>> various scenarios. Thanks for the feedback to the previous revision, I
>>> tried to incorporate those. The changes in the currenct patchset beyond
>>> the suggested fixes are mostly related to the replacement of retired
>>> ioctl calls that will not part of the upstreamed MSHV kernel driver.
>>
>>
>>> Magnus Kulke (26):
>>>     accel: Add Meson and config support for MSHV accelerator
>>
>>>     accel/mshv: Add accelerator skeleton
>>>     accel/mshv: Register memory region listeners
>>>     accel/mshv: Initialize VM partition
>>>     accel/mshv: Add vCPU creation and execution loop
>>>     accel/mshv: Add vCPU signal handling
>>>     accel/mshv: Handle overlapping mem mappings
>>
>> Due to my generic work on accelerators, I'll have to refactor these
>> patches. Obviously I don't want to break your implementation! Can
>> you add some (functional?) tests? Ideally we should be running
>> tests on our CI to ensure code doesn't bitrot.
> 
> NB our CI systems don't have HyperV available, so it is unrealistic
> for us to test it in our CI upstream.

OK. Hopefully meson will autodetect it on x86_64 Linux hosts so at least
we'll compile & link.
That said, IIUC our Xen-only job should now use --disable-mshv:

.gitlab-ci.d/crossbuilds.yml:181:cross-amd64-xen-only:
.gitlab-ci.d/crossbuilds.yml-182-  extends: .cross_accel_build_job
.gitlab-ci.d/crossbuilds.yml-183-  needs:
.gitlab-ci.d/crossbuilds.yml-184-    - job: amd64-debian-cross-container
.gitlab-ci.d/crossbuilds.yml-185-  variables:
.gitlab-ci.d/crossbuilds.yml-186-    IMAGE: debian-amd64-cross
.gitlab-ci.d/crossbuilds.yml-187-    ACCEL: xen
.gitlab-ci.d/crossbuilds.yml-188-    EXTRA_CONFIGURE_OPTS: --disable-tcg 
--disable-kvm
.gitlab-ci.d/crossbuilds.yml-189-


Tests are optionally run on CI, having a test we can run locally is
still valuable.