From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Yanan Wang <wangyanan55@huawei.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: Eduardo Habkost <eduardo@habkost.net>,
Peter Maydell <peter.maydell@linaro.org>,
Andrew Jones <drjones@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
wanghaibin.wang@huawei.com, Markus Armbruster <armbru@redhat.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH v5 01/14] qemu-options: Improve readability of SMP related Docs
Date: Tue, 28 Dec 2021 20:11:00 +0100 [thread overview]
Message-ID: <2e89a7a4-c0bd-3696-cf67-bb3f0c882d82@redhat.com> (raw)
In-Reply-To: <20211228092221.21068-2-wangyanan55@huawei.com>
On 12/28/21 10:22, Yanan Wang wrote:
> We have a description in qemu-options.hx for each CPU topology
> parameter to explain what it exactly means, and also an extra
> declaration for the target-specific one, e.g. "for PC only"
> when describing "dies", and "for PC, it's on one die" when
> describing "cores".
>
> Now we are going to introduce one more non-generic parameter
> "clusters", it will make the Doc less readable and if we still
> continue to use the legacy way to describe it.
>
> So let's at first make two tweaks of the Docs to improve the
> readability and also scalability:
> 1) In the -help text: Delete the extra specific declaration and
> describe each topology parameter level by level. Then add a
> note to declare that different machines may support different
> subsets and the actual meaning of the supported parameters
> will vary accordingly.
> 2) In the rST text: List all the sub-hierarchies currently
> supported in QEMU, and correspondingly give an example of
> -smp configuration for each of them.
>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
> qemu-options.hx | 76 ++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 59 insertions(+), 17 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-12-28 19:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 9:22 [PATCH v5 00/14] ARM virt: Introduce CPU clusters topology support Yanan Wang via
2021-12-28 9:22 ` [PATCH v5 01/14] qemu-options: Improve readability of SMP related Docs Yanan Wang via
2021-12-28 19:11 ` Philippe Mathieu-Daudé [this message]
2021-12-28 9:22 ` [PATCH v5 02/14] hw/core/machine: Introduce CPU cluster topology support Yanan Wang via
2021-12-28 19:17 ` Philippe Mathieu-Daudé
2021-12-29 3:48 ` wangyanan (Y) via
2021-12-29 10:44 ` Philippe Mathieu-Daudé
2021-12-29 13:04 ` wangyanan (Y) via
2021-12-29 15:44 ` Philippe Mathieu-Daudé
2022-01-14 11:34 ` Markus Armbruster
2021-12-28 9:22 ` [PATCH v5 03/14] hw/core/machine: Wrap target specific parameters together Yanan Wang via
2021-12-28 19:23 ` Philippe Mathieu-Daudé
2021-12-29 1:40 ` wangyanan (Y) via
2021-12-28 9:22 ` [PATCH v5 04/14] tests/unit/test-smp-parse: Add testcases for CPU clusters Yanan Wang via
2021-12-28 19:26 ` Philippe Mathieu-Daudé
2021-12-28 9:22 ` [PATCH v5 05/14] tests/unit/test-smp-parse: No need to explicitly zero MachineClass members Yanan Wang via
2021-12-28 15:58 ` Philippe Mathieu-Daudé
2021-12-28 9:22 ` [PATCH v5 06/14] tests/unit/test-smp-parse: Keep default MIN/MAX CPUs in machine_base_class_init Yanan Wang via
2021-12-28 19:28 ` Philippe Mathieu-Daudé
2021-12-28 9:22 ` [PATCH v5 07/14] MAINTAINERS: Self-recommended as reviewer of "Machine core" Yanan Wang via
2021-12-28 15:58 ` Philippe Mathieu-Daudé
2021-12-28 9:22 ` [PATCH v5 08/14] hw/arm/virt: Support clusters on ARM virt machines Yanan Wang via
2021-12-28 9:22 ` [PATCH v5 09/14] hw/arm/virt: Support cluster level in DT cpu-map Yanan Wang via
2021-12-28 9:22 ` [PATCH v5 10/14] hw/acpi/aml-build: Improve scalability of PPTT generation Yanan Wang via
2021-12-28 9:22 ` [PATCH v5 11/14] hw/arm/virt-acpi-build: Make an ARM specific PPTT generator Yanan Wang via
2021-12-28 9:22 ` [PATCH v5 12/14] tests/acpi/bios-tables-test: Allow changes to virt/PPTT file Yanan Wang via
2021-12-28 9:22 ` [PATCH v5 13/14] hw/arm/virt-acpi-build: Support cluster level in PPTT generation Yanan Wang via
2021-12-28 9:22 ` [PATCH v5 14/14] tests/acpi/bios-table-test: Update expected virt/PPTT file Yanan Wang via
2021-12-31 12:05 ` [PATCH v5 00/14] ARM virt: Introduce CPU clusters topology support Philippe Mathieu-Daudé
2022-01-03 9:08 ` wangyanan (Y) via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e89a7a4-c0bd-3696-cf67-bb3f0c882d82@redhat.com \
--to=philmd@redhat.com \
--cc=ani@anisinha.ca \
--cc=armbru@redhat.com \
--cc=drjones@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=wanghaibin.wang@huawei.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).