From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: Re: [PATCH] gitlab: Drop --static from s390x linux-user build
Date: Tue, 7 May 2024 08:03:56 +0200 [thread overview]
Message-ID: <2e99999c-d63d-4f9c-a407-8eee496a9d41@redhat.com> (raw)
In-Reply-To: <20240506202020.422514-1-richard.henderson@linaro.org>
On 06/05/2024 22.20, Richard Henderson wrote:
> The host does not have the correct libraries installed for static pie,
> which causes host/guest address space interference for some tests.
> There's no real gain from linking statically, so drop it.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> Per my suggestion in
>
> https://lore.kernel.org/qemu-devel/50c27a9f-fd75-4f8e-9a2d-488d8df4f9b9@linaro.org
>
>
> r~
> ---
> .gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml b/.gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml
> index 105981879f..3a2b1e1d24 100644
> --- a/.gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml
> +++ b/.gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml
> @@ -2,7 +2,7 @@
> # setup by the scripts/ci/setup/build-environment.yml task
> # "Install basic packages to build QEMU on Ubuntu 22.04"
>
> -ubuntu-22.04-s390x-all-linux-static:
> +ubuntu-22.04-s390x-all-linux:
> extends: .custom_runner_template
> needs: []
> stage: build
> @@ -15,7 +15,7 @@ ubuntu-22.04-s390x-all-linux-static:
> script:
> - mkdir build
> - cd build
> - - ../configure --enable-debug --static --disable-system
> + - ../configure --enable-debug-tcg --disable-system --disable-tools --disable-docs
Maybe mention the --disable-tools and --disable-docs in the commit message, too?
Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-05-07 6:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 20:20 [PATCH] gitlab: Drop --static from s390x linux-user build Richard Henderson
2024-05-07 6:03 ` Thomas Huth [this message]
2024-05-07 9:22 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e99999c-d63d-4f9c-a407-8eee496a9d41@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).