Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

[Halil Pasic <pasic@linux.vnet.ibm.com>]

On 09/19/2017 04:20 PM, Pierre Morel wrote:
> On 15/09/2017 19:01, Cornelia Huck wrote:
>> On Fri, 15 Sep 2017 09:27:58 +0200
>> Cornelia Huck <cohuck@redhat.com> wrote:
>>
>>> On Thu, 14 Sep 2017 18:50:29 +0200
>>> Halil Pasic <pasic@linux.vnet.ibm.com> wrote:
>>>
>>>> On 09/14/2017 04:26 PM, Cornelia Huck wrote:
>>
>>>>> There's quite some potential in this. We may want to make this a
>>>>> permanent addition.
>>>>>      
>>>>
>>>> I'm happy to contribute! I'm not sure how shall we proceed though.
>>>> Maybe with making a todo list?
>>>
>>> I think the first step would be to figure out the ids so we don't step
>>> on anyone's toes. Then maybe refactor a bit so that other testers can
>>> be added easily.
>>>
>>> For ideas about things to be tested, maybe put a list into the wiki?
>>
>> OK, I've created https://wiki.qemu.org/Testing/CCWTestDevice - let me
>> know if you need an account.
>>
> 
> Great!
> I just saw your email, it was waiting in my inbox.
> strange things happens some time. A good serie. strange things.
> neverless...
> 
> Seriously.
> Yes, I definitively need an account!
> 
> 
> Pierre
> 

@Connie
I would also like to have an account. I would also like to do a
v2 of this somewhere in the not too distant future. I intend
to address the issues pointed out by you here (chpid_type,
cu_type). Another question is whether this should go under
hw/misc/ like the pci-testdev? ccw-testdev would also probably
be a better file name (that ccw-tester) regardless of in which
folder does this belong. One more thing I am considering for
v2 is this make it extensible argument. I had something like
mode on my mind from the very beginning (fib would be one mode).
The idea was to provide a control ccw for setting/getting the mode
(something like virtio) as well as a device property for setting
the initial mode (so that guest does not have to know about it).

Regards,
Halil