From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwUxa-0007v6-Fy for qemu-devel@nongnu.org; Mon, 25 Sep 2017 11:06:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwUxW-0008VH-9v for qemu-devel@nongnu.org; Mon, 25 Sep 2017 11:06:14 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38488 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dwUxW-0008Uy-3q for qemu-devel@nongnu.org; Mon, 25 Sep 2017 11:06:10 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v8PF3dEL143813 for ; Mon, 25 Sep 2017 11:06:07 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 2d71c84ajm-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 25 Sep 2017 11:06:06 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 25 Sep 2017 16:06:05 +0100 References: <20170913132752.8484-1-pasic@linux.vnet.ibm.com> <20170913132752.8484-2-pasic@linux.vnet.ibm.com> <20170914162603.1cdabd09.cohuck@redhat.com> <0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com> <20170915092758.16ea52fc.cohuck@redhat.com> <20170915190118.03dc1b57.cohuck@redhat.com> <1301a0dc-755f-1670-1062-b70ea86802e0@linux.vnet.ibm.com> From: Halil Pasic Date: Mon, 25 Sep 2017 17:06:01 +0200 MIME-Version: 1.0 In-Reply-To: <1301a0dc-755f-1670-1062-b70ea86802e0@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Message-Id: <2ec0f5a8-b12e-1b4a-8d6f-ecddedeecc78@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pierre Morel , Cornelia Huck Cc: Dong Jia Shi , qemu-devel@nongnu.org, Christian Borntraeger On 09/19/2017 04:20 PM, Pierre Morel wrote: > On 15/09/2017 19:01, Cornelia Huck wrote: >> On Fri, 15 Sep 2017 09:27:58 +0200 >> Cornelia Huck wrote: >> >>> On Thu, 14 Sep 2017 18:50:29 +0200 >>> Halil Pasic wrote: >>> >>>> On 09/14/2017 04:26 PM, Cornelia Huck wrote: >> >>>>> There's quite some potential in this. We may want to make this a >>>>> permanent addition. >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=20 >>>> >>>> I'm happy to contribute! I'm not sure how shall we proceed though. >>>> Maybe with making a todo list? >>> >>> I think the first step would be to figure out the ids so we don't ste= p >>> on anyone's toes. Then maybe refactor a bit so that other testers can >>> be added easily. >>> >>> For ideas about things to be tested, maybe put a list into the wiki? >> >> OK, I've created https://wiki.qemu.org/Testing/CCWTestDevice - let me >> know if you need an account. >> >=20 > Great! > I just saw your email, it was waiting in my inbox. > strange things happens some time. A good serie. strange things. > neverless... >=20 > Seriously. > Yes, I definitively need an account! >=20 >=20 > Pierre >=20 @Connie I would also like to have an account. I would also like to do a v2 of this somewhere in the not too distant future. I intend to address the issues pointed out by you here (chpid_type, cu_type). Another question is whether this should go under hw/misc/ like the pci-testdev? ccw-testdev would also probably be a better file name (that ccw-tester) regardless of in which folder does this belong. One more thing I am considering for v2 is this make it extensible argument. I had something like mode on my mind from the very beginning (fib would be one mode). The idea was to provide a control ccw for setting/getting the mode (something like virtio) as well as a device property for setting the initial mode (so that guest does not have to know about it). Regards, Halil