qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Chris Laplante <chris@laplante.io>, qemu-devel@nongnu.org
Cc: Joel Stanley <joel@jms.id.au>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org
Subject: Re: [PATCH v3 6/6] qtest: microbit-test: add tests for nRF51 DETECT
Date: Mon, 31 Jul 2023 07:17:16 +0200	[thread overview]
Message-ID: <2ec3f8f8-7c6e-f3d1-dbb2-f0700b606603@redhat.com> (raw)
In-Reply-To: <20230728160324.1159090-7-chris@laplante.io>

On 28/07/2023 18.05, Chris Laplante wrote:
> Exercise the DETECT mechanism of the GPIO peripheral.
> 
> Signed-off-by: Chris Laplante <chris@laplante.io>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   tests/qtest/microbit-test.c | 42 +++++++++++++++++++++++++++++++++++++
>   1 file changed, 42 insertions(+)
> 
> diff --git a/tests/qtest/microbit-test.c b/tests/qtest/microbit-test.c
> index 6022a92b6a..8f87810cd5 100644
> --- a/tests/qtest/microbit-test.c
> +++ b/tests/qtest/microbit-test.c
> @@ -393,6 +393,47 @@ static void test_nrf51_gpio(void)
>       qtest_quit(qts);
>   }
>   
> +static void test_nrf51_gpio_detect(void) {
> +    QTestState *qts = qtest_init("-M microbit");
> +    int i;
> +
> +    // Connect input buffer on pins 1-7, configure SENSE for high level

QEMU coding style says that // comments should be avoided. See 
docs/devel/style.rst , section "Comment style". Please use /* ... */ 
comments instead.

  Thanks,
   Thomas



  reply	other threads:[~2023-07-31  5:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28 16:04 [PATCH v3 0/6] Add nRF51 DETECT signal with test Chris Laplante
2023-07-28 16:04 ` [PATCH v3 1/6] hw/gpio/nrf51: implement DETECT signal Chris Laplante
2023-07-28 16:04 ` [PATCH v3 2/6] qtest: factor out qtest_install_gpio_out_intercept Chris Laplante
2023-07-28 16:04 ` [PATCH v3 3/6] qtest: implement named interception of out-GPIO Chris Laplante
2023-07-28 16:05 ` [PATCH v3 4/6] qtest: bail from irq_intercept_in if name is specified Chris Laplante
2023-07-28 16:05 ` [PATCH v3 5/6] qtest: irq_intercept_[out/in]: return FAIL if no intercepts are installed Chris Laplante
2023-07-28 16:05 ` [PATCH v3 6/6] qtest: microbit-test: add tests for nRF51 DETECT Chris Laplante
2023-07-31  5:17   ` Thomas Huth [this message]
2023-08-03 13:21 ` [PATCH v3 0/6] Add nRF51 DETECT signal with test Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ec3f8f8-7c6e-f3d1-dbb2-f0700b606603@redhat.com \
    --to=thuth@redhat.com \
    --cc=chris@laplante.io \
    --cc=joel@jms.id.au \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).