From: Richard Henderson <richard.henderson@linaro.org>
To: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix preadv/pwritev offsets
Date: Thu, 5 Apr 2018 13:40:37 +1000 [thread overview]
Message-ID: <2ecf3678-6f4e-4683-b439-40e62ded2ae5@linaro.org> (raw)
In-Reply-To: <20180405013321.3129-1-jcmvbkbc@gmail.com>
On 04/05/2018 11:33 AM, Max Filippov wrote:
> +static void target_low_high_to_host_low_high(abi_ulong tlow,
> + abi_ulong thigh,
> + unsigned long *hlow,
> + unsigned long *hhigh)
> +{
> +#if TARGET_LONG_BITS == HOST_LONG_BITS
> + *hlow = tlow;
> + *hhigh = thigh;
> +#elif TARGET_LONG_BITS < HOST_LONG_BITS
> + *hlow = tlow | (unsigned long)thigh << TARGET_LONG_BITS;
> + *hhigh = 0;
> +#else
> + *hlow = (unsigned long)tlow;
> + *hhigh = (unsigned long)(thigh >> HOST_LONG_BITS);
> +#endif
This third clause does not look right.
It might have been thigh >> HOST_LONG_BITS, which is good for the specific
cases (32, 64) that we will always have. But you'd certainly want to not
pretend otherwise by only checking relative sizes.
r~
prev parent reply other threads:[~2018-04-05 3:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 1:33 [Qemu-devel] [PATCH] linux-user: fix preadv/pwritev offsets Max Filippov
2018-04-05 3:40 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ecf3678-6f4e-4683-b439-40e62ded2ae5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=jcmvbkbc@gmail.com \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).