From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 482F4CEBF8C for ; Fri, 27 Sep 2024 09:23:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1su7Bm-00088a-29; Fri, 27 Sep 2024 05:23:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1su7Bj-000868-3A for qemu-devel@nongnu.org; Fri, 27 Sep 2024 05:22:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1su7Bg-0001bQ-SD for qemu-devel@nongnu.org; Fri, 27 Sep 2024 05:22:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727428975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kXIhZy2E5QsXf9jKThB1fGdoBehl66iiOTHOmBV3nf0=; b=Hqm0j5jBc2qXGBTnJlFLxfIUA9v/cPlOh+f6BAoztyl7FCTo2NTfZ6DcyaXbFHuMWXpM8+ 306ecQPf7k7gfNuuXeLCpMwyXMFjrX3EoEqIrjo8zdUE4o6zKqlM4L2W6dThT5JgSsphGr v5nt6OyNboo0IC6YOO5psYsRrwaetRA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-zNCUmJNQMvKM62KrhfmPAA-1; Fri, 27 Sep 2024 05:22:53 -0400 X-MC-Unique: zNCUmJNQMvKM62KrhfmPAA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42e77b5d3dcso12006425e9.1 for ; Fri, 27 Sep 2024 02:22:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727428972; x=1728033772; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kXIhZy2E5QsXf9jKThB1fGdoBehl66iiOTHOmBV3nf0=; b=AiohD4s62SZ3P+l0vCgcntdbIgz+lJEp58m91V7O2ykX9S5jV3tquqYTEXYNdLki1z +2xX9/zYdibOhTBt2khbjPngaadxLDRnZj94ggDvx8CRwU+KsVy98W50N7Z/fD1cRO2X hPUoX2qPK0E+ty/9t6OW8w3lZ+fgsMzWMsDx1mN/EbObBpPMIAjqdx35L/CVqBoh6YuZ dy1N3IvAqykduYEpqDCoyxbr1FzCmeXaNIU53C/iKZVnEwmpRtpbYVfWAH4c0BG7GH37 +uEBD1mIhhwsrAFNsPVx/srYSfOHlLSOQzZl4q+XyjWfXzzl8tlx4AZPO93xra2ZjpJA 78bw== X-Forwarded-Encrypted: i=1; AJvYcCWOsd9vw2Pbh4mNGBiyDEWEzbB623hkUquhDVLV+bm8NK3LAE14jWVYKnhFhNrfc7QehZ5pWdjFGxHL@nongnu.org X-Gm-Message-State: AOJu0YwVuL0xrQF+JfiguZZR9OdUZW0u8L895Bc/0+pkwmuywzN3q+/M 7UjXQ64onpk+pb91s3bvNkztXSbMV/qiUf3s6SDgCUjUPPEDsJ5VxkHQ/0fLP4pF46yRdlKAJ7H s4Go6jZSzCziQr53R3wDiqw9T8m0mp2BIeRufisHEF8f9hpp3+qEk X-Received: by 2002:a05:600c:350f:b0:42c:b34d:720c with SMTP id 5b1f17b1804b1-42f5840ce88mr15500675e9.4.1727428971941; Fri, 27 Sep 2024 02:22:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGS9uID04Olo2XVfVqNTzd7p6qe70Kn0XX36rn/Hcof+iaB8j8IV7EAudvy03L5Jx/HWs6w9g== X-Received: by 2002:a05:600c:350f:b0:42c:b34d:720c with SMTP id 5b1f17b1804b1-42f5840ce88mr15500525e9.4.1727428971522; Fri, 27 Sep 2024 02:22:51 -0700 (PDT) Received: from [192.168.0.7] (ip-109-42-48-176.web.vodafone.de. [109.42.48.176]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cd5730ecasm1904892f8f.81.2024.09.27.02.22.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 02:22:51 -0700 (PDT) Message-ID: <2ed19b27-bd81-4782-9c8b-910443a16d7b@redhat.com> Date: Fri, 27 Sep 2024 11:22:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 7/7] hw/gpio/aspeed: Add test case for AST2700 To: Jamin Lin , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , Joel Stanley , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" Cc: Troy Lee , Yunlin Tang References: <20240927073144.2303522-1-jamin_lin@aspeedtech.com> <20240927073144.2303522-8-jamin_lin@aspeedtech.com> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.131, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 27/09/2024 10.12, Jamin Lin wrote: > Hi Cedric, > >> Subject: [PATCH v4 7/7] hw/gpio/aspeed: Add test case for AST2700 >> >> Add test case to test GPIO output and input pins from A0 to D7 for AST2700. >> >> Signed-off-by: Jamin Lin >> --- >> tests/qtest/aspeed_gpio-test.c | 64 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 64 insertions(+) >> >> diff --git a/tests/qtest/aspeed_gpio-test.c b/tests/qtest/aspeed_gpio-test.c >> index d38f51d719..8ae42a8da5 100644 >> --- a/tests/qtest/aspeed_gpio-test.c >> +++ b/tests/qtest/aspeed_gpio-test.c >> @@ -33,6 +33,10 @@ >> #define GPIO_ABCD_DATA_VALUE 0x000 >> #define GPIO_ABCD_DIRECTION 0x004 >> >> +/* AST2700 */ >> +#define AST2700_GPIO_BASE 0x14C0B000 >> +#define GPIOA0_CONTROL 0x180 >> + >> static void test_set_colocated_pins(const void *data) { >> QTestState *s = (QTestState *)data; @@ -72,6 +76,61 @@ static void >> test_set_input_pins(const void *data) >> g_assert_cmphex(value, ==, 0xffffffff); } >> >> +static void test_2700_output_pins(const void *data) { >> + QTestState *s = (QTestState *)data; >> + uint32_t offset = 0; >> + uint32_t value = 0; >> + uint32_t pin = 0; >> + >> + for (char c = 'A'; c <= 'D'; c++) { >> + for (int i = 0; i < 8; i++) { >> + offset = AST2700_GPIO_BASE + GPIOA0_CONTROL + (pin * 4); >> + >> + /* output direction and output hi */ >> + qtest_writel(s, offset, 0x00000003); >> + value = qtest_readl(s, offset); >> + g_assert_cmphex(value, ==, 0x00000003); >> + >> + /* output direction and output low */ >> + qtest_writel(s, offset, 0x00000002); >> + value = qtest_readl(s, offset); >> + g_assert_cmphex(value, ==, 0x00000002); >> + pin++; >> + } >> + } >> +} >> + >> +static void test_2700_input_pins(const void *data) { >> + QTestState *s = (QTestState *)data; >> + char name[16]; >> + uint32_t offset = 0; >> + uint32_t value = 0; >> + uint32_t pin = 0; >> + >> + for (char c = 'A'; c <= 'D'; c++) { >> + for (int i = 0; i < 8; i++) { >> + sprintf(name, "gpio%c%d", c, i); >> + offset = AST2700_GPIO_BASE + GPIOA0_CONTROL + (pin * 4); >> + /* input direction */ >> + qtest_writel(s, offset, 0); >> + >> + /* set input */ >> + qtest_qom_set_bool(s, "/machine/soc/gpio", name, true); >> + value = qtest_readl(s, offset); >> + g_assert_cmphex(value, ==, 0x00002000); >> + >> + /* clear input */ >> + qtest_qom_set_bool(s, "/machine/soc/gpio", name, false); >> + value = qtest_readl(s, offset); >> + g_assert_cmphex(value, ==, 0); >> + pin++; >> + } >> + } >> +} >> + >> + >> int main(int argc, char **argv) >> { >> QTestState *s; >> @@ -83,6 +142,11 @@ int main(int argc, char **argv) >> qtest_add_data_func("/ast2600/gpio/set_colocated_pins", s, >> test_set_colocated_pins); >> qtest_add_data_func("/ast2600/gpio/set_input_pins", s, >> test_set_input_pins); >> + >> + s = qtest_init("-machine ast2700-evb"); >> + qtest_add_data_func("/ast2700/gpio/input_pins", s, >> test_2700_input_pins); >> + qtest_add_data_func("/ast2700/gpio/out_pins", s, >> + test_2700_output_pins); >> + >> r = g_test_run(); >> qtest_quit(s); >> > It seems I need to check arch for AST2700 to fix the following errors. > > int main(int argc, char **argv) > { > const char *arch = qtest_get_arch(); > QTestState *s; > int r; > > g_test_init(&argc, &argv, NULL); > > s = qtest_init("-machine ast2600-evb"); > qtest_add_data_func("/ast2600/gpio/set_colocated_pins", s, > test_set_colocated_pins); > qtest_add_data_func("/ast2600/gpio/set_input_pins", s, test_set_input_pins); > > if (strcmp(arch, "aarch64") == 0) { > s = qtest_init("-machine ast2700-evb"); > qtest_add_data_func("/ast2700/gpio/input_pins", > s, test_2700_input_pins); > qtest_add_data_func("/ast2700/gpio/out_pins", s, test_2700_output_pins); > } > > r = g_test_run(); > qtest_quit(s); > > return r; > } > > qemu-system-arm: unsupported machine type: "ast2700-evb" > Use -machine help to list supported machines If ast2700 is aarch64 only, you rather might need to put the test into a separate file, since aspeed_gpio-test.c is for the 32-bit arm machines only, isn't it? (see tests/qtest/meson.build) Thomas