From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables
Date: Tue, 28 Feb 2017 20:04:38 -0600 [thread overview]
Message-ID: <2ee01c83-d50f-6e23-be73-871b0c0ef939@redhat.com> (raw)
In-Reply-To: <20170228122901.24520-2-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On 02/28/2017 06:29 AM, Daniel P. Berrange wrote:
> The only functional difference between the GENERATED_HEADERS
> and GENERATED_SOURCES variables is that 'Makefile' has a
> dependancy on GENERATED_HEADERS, causing generated header files
s/dependancy/dependency/
> to be created immediatey at the start of the build process.
s/immediatey/immediately/
> There is no reason why this early creation should be restricted
> to the .h files, and not include .c files too. Merge both of
> the variables into a single GENERATED_FILES variable to make
> it clear it is for any type of generated file.
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-03-01 2:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 12:28 [Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir Daniel P. Berrange
2017-02-28 12:29 ` [Qemu-devel] [PATCH 1/2] makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables Daniel P. Berrange
2017-03-01 2:04 ` Eric Blake [this message]
2017-02-28 12:29 ` [Qemu-devel] [PATCH 2/2] makefile: generate trace-events-all upfront Daniel P. Berrange
2017-02-28 12:47 ` [Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir Fam Zheng
2017-03-01 12:19 ` Stefan Hajnoczi
2017-03-01 12:20 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ee01c83-d50f-6e23-be73-871b0c0ef939@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).