From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09DE0CA0EFA for ; Mon, 25 Aug 2025 10:35:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uqUWt-0001T4-Sj; Mon, 25 Aug 2025 06:34:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqUWq-0001Sn-Ra for qemu-devel@nongnu.org; Mon, 25 Aug 2025 06:34:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqUWo-0006cT-Hw for qemu-devel@nongnu.org; Mon, 25 Aug 2025 06:34:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756118056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/wk04dinmIPpQ4cVK96z+fxLoh2FCqJ98KQMCTEN+ns=; b=O7gugiUREvJCypDF9ChgerlQXgV2w9oHZ+KW3GMTzd4Of78tF21NErcq70NwqkVhcZzo2h Dg1Q5pnmimwC57d1C8aoVW3KNr3BNq6dEobUrsp5xnbJOpmcCFDxFxPMEdpO2/R5+YFgL7 nAO/DwEt4HQqa2t264f5Rd1JOWYVonM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-VD5xUD7QOk6TrPfBQuIC_w-1; Mon, 25 Aug 2025 06:34:14 -0400 X-MC-Unique: VD5xUD7QOk6TrPfBQuIC_w-1 X-Mimecast-MFC-AGG-ID: VD5xUD7QOk6TrPfBQuIC_w_1756118053 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3b9edf5b346so1834172f8f.3 for ; Mon, 25 Aug 2025 03:34:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756118053; x=1756722853; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/wk04dinmIPpQ4cVK96z+fxLoh2FCqJ98KQMCTEN+ns=; b=otHGyYdgmpphWqh7TONcFKvqKWsmlT0PQSbgx+TNyhpe3GALtYYnYQIkq1Ja9RGItV JoQrcJaOzS0hRDqAiFG50IfnUTRI2Q7fJ+PDKP5Q0vVb8c0QTc9wrvXhapEJRQN4JAW2 0+dVkfJjOPf67IwnLBRecVGiYKzyAIprFDBpjxoUNKV7qHUAIc4OJhYVRMEFS4dI73Xw 5fxcasdmK4EKCCqbWyOiPYjrYJ6ac/IZ1ooK9GjowD44d7An25mw7rADtZN8UE6xjMoI 5Sgj2A6wlO1xDOsc8bylMg/6Ridhx1NExyA6UMfYQOH1Pw7TfRZAmzT+M/xrRrs2u3mT O0iw== X-Forwarded-Encrypted: i=1; AJvYcCX47ysUBbCQxLqBeK2vXvyG20mpX+YlopyyxmwEz+ctPgnLSl4lkWzEBKohHcbZ5g1rhFdn+FRLGG18@nongnu.org X-Gm-Message-State: AOJu0Yx0S6KeCL0bqj7PaIkOwWWNIYhoTisrQhbJIh51z6mncRUDl3P8 R+Glmb2QsJtEzu3LIDs5/sZslvS3SJ7fhgnjkbgXQlg+upN3tK1hMcm4k6euwj6hEDcwG53sBmQ 6LjpTsAbOZMGEQejdWMy+5aomEvabyPy4aJPJiHOaKzK6l4wYY6BH9AK8 X-Gm-Gg: ASbGnctDYy1KLQFc2y/i7WdAnq5hdZOx6tMUi3DVC1yKbrmorudpOZgOwATGjwNSmpT mSNOXmMhiTCUlnC9tjSsfE+LqaA/IvSjcOxpLitJISmA7UisNvlgiN8ZepwztgcnhjIg0fWdpTV CkyyPEESXXyXLiUwyY2o4tMpWmEgz2qsm5gJp0j2LGsKDW3Mc4ucqt44gSpasAHR7MRr0sSo/VU A099d3b67FwT2mjguD+TzDYGRM1PxrNeTXvy7uyc74YYZ3eJWXh8+MGKsCP7Pa92v3bi1She2nW uo7tMWr9Bf0ixTlrqzsbgin05UGAloMZd7WOFyT/u2EC+EiY/QHve8luuDfqd0/bVZoTu+T9vtU 3Os4= X-Received: by 2002:a05:6000:3105:b0:3b8:d672:3cf8 with SMTP id ffacd0b85a97d-3c5dcb10b6amr9369385f8f.43.1756118053001; Mon, 25 Aug 2025 03:34:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9jFjqHivEN9ZDtt6uqJw4epGS8I3riUF1Ys533XnSs5/ygn1HXKWbw/Y/YP5CxF8KO5Ym2Q== X-Received: by 2002:a05:6000:3105:b0:3b8:d672:3cf8 with SMTP id ffacd0b85a97d-3c5dcb10b6amr9369368f8f.43.1756118052523; Mon, 25 Aug 2025 03:34:12 -0700 (PDT) Received: from [192.168.0.6] (ltea-047-064-112-084.pools.arcor-ip.net. [47.64.112.84]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c711bb1d3esm11012918f8f.55.2025.08.25.03.34.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Aug 2025 03:34:12 -0700 (PDT) Message-ID: <2ef8923b-18f5-47c6-b688-c9fa5b4fb0e4@redhat.com> Date: Mon, 25 Aug 2025 12:34:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] tests/functional: Adapt reverse_debugging to run w/o Avocado To: Gustavo Romero , qemu-devel@nongnu.org, alex.bennee@linaro.org Cc: qemu-arm@nongnu.org, "Daniel P. Berrange" References: <20250819143916.4138035-1-gustavo.romero@linaro.org> <20250819143916.4138035-5-gustavo.romero@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250819143916.4138035-5-gustavo.romero@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 19/08/2025 16.39, Gustavo Romero wrote: > This commit removes Avocado as a dependency for running the > reverse_debugging test. > > The main benefit, beyond eliminating an extra dependency, is that there > is no longer any need to handle GDB packets manually. This removes the > need for ad-hoc functions dealing with endianness and arch-specific > register numbers, making the test easier to read. The timeout variable > is also removed, since Meson now manages timeouts automatically. > > The reverse_debugging test is now executed through a runner, because it > requires GDB in addition to QMP. The runner is responsible for invoking > GDB with the appropriate arguments and for passing the test script to > GDB. > > Since the test now runs inside GDB, its output, particularly from > 'stepi' commands, which cannot be disabled, interleaves with the TAP > output from unittest. To avoid this conflict, the test no longer uses > Meson’s 'tap' protocol and instead relies on the simpler 'exitcode' > protocol. > > reverse_debugging is kept "skipped" for aarch64, ppc64, and x86_64, so > won't run unless QEMU_TEST_FLAKY_TESTS=1 is set in the test environment, > before running 'make check-functional' or 'meson test [...]'. > > Signed-off-by: Gustavo Romero > --- ... > diff --git a/tests/functional/test_aarch64_reverse_debug.py b/tests/functional/test_aarch64_reverse_debug.py > index 58d4532835..8b6f82c227 100755 > --- a/tests/functional/test_aarch64_reverse_debug.py > +++ b/tests/functional/test_aarch64_reverse_debug.py ... > - KERNEL_ASSET = Asset( > + ASSET_KERNEL = Asset( > ('https://archives.fedoraproject.org/pub/archive/fedora/linux/' > 'releases/29/Everything/aarch64/os/images/pxeboot/vmlinuz'), > '7e1430b81c26bdd0da025eeb8fbd77b5dc961da4364af26e771bd39f379cbbf7') > @@ -30,9 +29,9 @@ class ReverseDebugging_AArch64(ReverseDebugging): > def test_aarch64_virt(self): > self.set_machine('virt') > self.cpu = 'cortex-a53' > - kernel_path = self.KERNEL_ASSET.fetch() > + kernel_path = self.ASSET_KERNEL.fetch() > self.reverse_debugging(args=('-kernel', kernel_path)) Ouch, that "KERNEL_ASSET" is worth to be sent as a separate bugfix (without the proper "ASSET_" prefix, the asset won't be precached properly). Could you maybe send this as a separate patch, please? Thanks, Thomas