From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F54CC433E0 for ; Thu, 25 Jun 2020 19:33:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3409D20767 for ; Thu, 25 Jun 2020 19:33:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CBTxjL2p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3409D20767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joXcR-0000vn-HK for qemu-devel@archiver.kernel.org; Thu, 25 Jun 2020 15:33:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joXbg-0000Pl-9t for qemu-devel@nongnu.org; Thu, 25 Jun 2020 15:32:20 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:51355 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1joXbZ-0008Uz-ET for qemu-devel@nongnu.org; Thu, 25 Jun 2020 15:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593113531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JUef9MpqF+fO9MoZZljTqn+KLJv0PJ4766fMdtaDI90=; b=CBTxjL2pHG6pavpW3PFJ43uQYto0clcYUq0B+zZB+wT67BjmdaKQ/9z4CAUHTPy4Rw9N3Q WDPVh8tb4jpyaZRsnFQ6EybvIZED+TMjZYuX/A8D7rcYxktYDFBwXBA8ORoAMb4tkwjTKX MgoXERL2pq3K5zw8Cb+/0E/xJctAWHY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-74TyfRMzN16DiHLc8LKSFA-1; Thu, 25 Jun 2020 15:32:06 -0400 X-MC-Unique: 74TyfRMzN16DiHLc8LKSFA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DBD7E107ACCA; Thu, 25 Jun 2020 19:32:04 +0000 (UTC) Received: from [10.3.114.107] (ovpn-114-107.phx2.redhat.com [10.3.114.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA3C15C240; Thu, 25 Jun 2020 19:32:01 +0000 (UTC) Subject: Re: [PATCH 1/4] iotests: QemuIoInteractive: use qemu_io_args_no_fmt To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20200625142540.24589-1-vsementsov@virtuozzo.com> <20200625142540.24589-2-vsementsov@virtuozzo.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <2f01d8df-ed77-aab5-2f9a-120bbfa4b823@redhat.com> Date: Thu, 25 Jun 2020 14:32:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200625142540.24589-2-vsementsov@virtuozzo.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/25 00:45:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, den@openvz.org, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/25/20 9:25 AM, Vladimir Sementsov-Ogievskiy wrote: > All users of QemuIoInteractive provides -f argument, so it's incorrect So far, all users is just test 205; although your series adds test 209 that does likewise. "incorrect" is a bit harsh since you can specify -f more than once (last one wins); maybe "inefficient" is better wording. > to use qemu_io_args, which contains -f too. Let's use > qemu_io_args_no_fmt, which also makes possible to use --image-opts with > QemuIoInteractive in the following patch. Reviewed-by: Eric Blake > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/iotests.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py > index 5ea4c4df8b..efe9958f5e 100644 > --- a/tests/qemu-iotests/iotests.py > +++ b/tests/qemu-iotests/iotests.py > @@ -211,7 +211,7 @@ def get_virtio_scsi_device(): > > class QemuIoInteractive: > def __init__(self, *args): > - self.args = qemu_io_args + list(args) > + self.args = qemu_io_args_no_fmt + list(args) > self._p = subprocess.Popen(self.args, stdin=subprocess.PIPE, > stdout=subprocess.PIPE, > stderr=subprocess.STDOUT, > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org