From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 320E4C433B4 for ; Tue, 20 Apr 2021 12:51:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94570610A1 for ; Tue, 20 Apr 2021 12:51:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94570610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYpqn-0006AL-ES for qemu-devel@archiver.kernel.org; Tue, 20 Apr 2021 08:51:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYpp8-00058Y-Df for qemu-devel@nongnu.org; Tue, 20 Apr 2021 08:49:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32958) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYpp6-0005lW-Uc for qemu-devel@nongnu.org; Tue, 20 Apr 2021 08:49:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618922988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2WzuW8ARtrZKcpf6Ea9sLVdjRmpk2yq+ywpVVYOvjaI=; b=b8Iavjg0c53bqSD8t0D6RS9LuN7E+mx6gLuTnq03GQdF2i9sGNdi7Ln/nzmy2522nakm7U 0Hn6L+nxng/SGwNhwRvTnuFDstS5kqC2aiiHv78540AHr2Nth6nteIvU8foW8Py/HWafM5 jp7QcjD965Z8SuGkL11iCfFzuIo97E8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-D05bgZpzNNu6sO4_44njuA-1; Tue, 20 Apr 2021 08:49:44 -0400 X-MC-Unique: D05bgZpzNNu6sO4_44njuA-1 Received: by mail-wm1-f71.google.com with SMTP id y7-20020a1c4b070000b02901357a988015so1637362wma.5 for ; Tue, 20 Apr 2021 05:49:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=2WzuW8ARtrZKcpf6Ea9sLVdjRmpk2yq+ywpVVYOvjaI=; b=OpBOzEScaEtyhlfb3hfxKUomZ+pUN1AVT1wxyKbfUZRPa19297rnOdd86a4xuuScCr 0Ng0YP8sEpHPk63G+S4baOas/T9PiwKbDduhlHnaqiP6HKWtdSEkRUPy2twNJ8qN+Gjo ylZOiaBMbkRXbPlfmetmPw3+WhQdiFOQvOyqGC7f0btawJAjlQkA84EKpWm4KcISd0XT 6ui0vYvwxEZEGA3iQUACfTq6rxBN9efxmRFxH//XtQbqQ4cagCo5woImqqLROpZ3wYbN HpI3QdY9yIVWjK5KE9wLUDnlOFGwodH35JBmZqa+zPpSB/pP6PgqwekXwANY+YXLopfI cKUg== X-Gm-Message-State: AOAM533T7a3slMSy2cnOjYmztBVcRYMIJYXeaiLPW6wc5mqkUTskPh8/ zoWspWjtyIUYcCJi5/FGdQDvYrE4HJHKxwOHOc4sOgRbqjcm7LAS8FZsUOSC9xclqCe3c5QdHgd GerQ5YAIh/YebKZ8= X-Received: by 2002:a1c:4e01:: with SMTP id g1mr4487237wmh.48.1618922983282; Tue, 20 Apr 2021 05:49:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMAC9TGzJIi4RtJE8a0FNHYkUSjkMF+tXiwQZSuodgg+rJVYGNFuajsJPvaCX5FzXenSZ4TQ== X-Received: by 2002:a1c:4e01:: with SMTP id g1mr4487218wmh.48.1618922983100; Tue, 20 Apr 2021 05:49:43 -0700 (PDT) Received: from [192.168.3.132] (p4ff2390a.dip0.t-ipconnect.de. [79.242.57.10]) by smtp.gmail.com with ESMTPSA id l13sm10616998wrt.14.2021.04.20.05.49.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Apr 2021 05:49:42 -0700 (PDT) Subject: Re: [RFC v2 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c To: Claudio Fontana , Cornelia Huck , Thomas Huth , Richard Henderson References: <20210420103616.32731-1-cfontana@suse.de> <20210420103616.32731-3-cfontana@suse.de> From: David Hildenbrand Organization: Red Hat Message-ID: <2f05cdb6-ecf4-8af9-dd05-acb17e3d1314@redhat.com> Date: Tue, 20 Apr 2021 14:49:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210420103616.32731-3-cfontana@suse.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 20.04.21 12:36, Claudio Fontana wrote: > we stop short of renaming the actual qom object though, > so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu". > > Signed-off-by: Claudio Fontana > --- > hw/s390x/{tod-qemu.c => tod-tcg.c} | 0 > hw/s390x/meson.build | 2 +- > 2 files changed, 1 insertion(+), 1 deletion(-) > rename hw/s390x/{tod-qemu.c => tod-tcg.c} (100%) > > diff --git a/hw/s390x/tod-qemu.c b/hw/s390x/tod-tcg.c > similarity index 100% > rename from hw/s390x/tod-qemu.c > rename to hw/s390x/tod-tcg.c > diff --git a/hw/s390x/meson.build b/hw/s390x/meson.build > index a4d355b4db..72f48635cb 100644 > --- a/hw/s390x/meson.build > +++ b/hw/s390x/meson.build > @@ -25,7 +25,7 @@ s390x_ss.add(when: 'CONFIG_KVM', if_true: files( > 'pv.c', > )) > s390x_ss.add(when: 'CONFIG_TCG', if_true: files( > - 'tod-qemu.c', > + 'tod-tcg.c', > )) > > s390x_ss.add(when: 'CONFIG_S390_CCW_VIRTIO', if_true: files('s390-virtio-ccw.c')) > I'd just swap this patch with #1 -- or even squash them. -- Thanks, David / dhildenb