From: Paolo Bonzini <pbonzini@redhat.com>
To: Matheus Kowalczuk Ferst <matheus.ferst@eldorado.org.br>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] configure: ignore --make
Date: Wed, 8 Jun 2022 17:54:46 +0200 [thread overview]
Message-ID: <2f19b91a-e641-9d20-0158-c7bb71693ad5@redhat.com> (raw)
In-Reply-To: <75ed39ec-ed5c-a9b6-c51e-94e26a333316@eldorado.org.br>
On 6/8/22 16:21, Matheus Kowalczuk Ferst wrote:
> On a clean build on FreeBSD with this patch, I got:
>
> ../meson.build:3641:0: ERROR: Key MAKE is not in dict
>
> So it seems that we need to remove the use of MAKE in meson.build too.
Oops, yes. That's the typical "forget git commit --amend before sending
out" mistake for me.
> Also, we will not have this error at configure-time anymore, but I
> suppose that *BSD users will identify the problem if they try to build
> with non-gnu make.
Yeah, my guess was that "try ./configure && make" with GNU Make
installed is the more common failure mode, since QEMU is certainly not
the only package that requires GNU Make.
Alternatively, I can leave in the check for GNU Make, or move it to
meson as a "now type "make" to build QEMU" kind of message, and still
remove the unused --make option.
Paolo
next prev parent reply other threads:[~2022-06-08 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 10:49 [PATCH] configure: ignore --make Paolo Bonzini
2022-06-08 14:21 ` Matheus Kowalczuk Ferst
2022-06-08 15:54 ` Paolo Bonzini [this message]
2022-06-08 17:19 ` Matheus Kowalczuk Ferst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f19b91a-e641-9d20-0158-c7bb71693ad5@redhat.com \
--to=pbonzini@redhat.com \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).