qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH] Simplify the .gitignore file
Date: Tue, 8 Sep 2020 07:50:52 -0500	[thread overview]
Message-ID: <2f1b8cb5-6639-a530-1467-28fb6a89c926@redhat.com> (raw)
In-Reply-To: <20200907174255.179652-1-thuth@redhat.com>

On 9/7/20 12:42 PM, Thomas Huth wrote:
> Now that we always do out-of-tree builds (and the in-tree builds are
> faked via a "build" directory), we can simplify out .gitignore file

s/out/our/

> quite a bit.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   .gitignore | 158 -----------------------------------------------------
>   1 file changed, 158 deletions(-)
> 

I like the idea.  As Phillipe pointed out, there are still a few files 
that may be created by merely running './configure' or common editor 
droppings or workflow setups that are still worth ignoring, but as most 
of these truly no longer appear during a fresh checkout, it makes sense 
to clean it up.

Someone who still wants to use 'fake in-tree' builds and creates 
symlinks for themselves will no longer have those symlinks ignored by 
this pruned file, but can edit their own .git/info/exclude file to match 
their preferences.

> diff --git a/.gitignore b/.gitignore
> index 4ccb9ed975..bb916594eb 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,165 +1,7 @@
>   /GNUmakefile
>   /build/

Our 'fake in-tree' build uses just 'build', but ignoring '/build*/' 
might be wiser to automatically ignore all other variations on the theme 
of a subdirectory per build.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



  parent reply	other threads:[~2020-09-08 12:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 17:42 [PATCH] Simplify the .gitignore file Thomas Huth
2020-09-07 19:43 ` Philippe Mathieu-Daudé
2020-09-08 14:41   ` Thomas Huth
2020-09-08 14:50     ` Thomas Huth
2020-09-08 16:04     ` Philippe Mathieu-Daudé
2020-09-09  7:24     ` Markus Armbruster
2020-09-08 12:50 ` Eric Blake [this message]
2020-09-09  7:58   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f1b8cb5-6639-a530-1467-28fb6a89c926@redhat.com \
    --to=eblake@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).