From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 4/6] target/tricore: Refactor PCXI/ICR register fields
Date: Sat, 20 May 2023 08:10:50 -0700 [thread overview]
Message-ID: <2f1fbb76-0d9f-769f-293d-ff346b943998@linaro.org> (raw)
In-Reply-To: <906dbffa-c677-1192-fedc-5664e61f8255@linaro.org>
On 5/19/23 08:02, Philippe Mathieu-Daudé wrote:
> Could it be clearer to add a 'icr_ie_mask' field in CPUTriCoreState,
> initialized once in tricore_cpu_realizefn() and avoid this if/else/ in
> translation here, simply using the initialized mask?
If its for use in the translator, put it in DisasContext.
r~
next prev parent reply other threads:[~2023-05-20 15:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 13:36 [PATCH 0/6] TriCore PCXI/ICR register fixes Bastian Koppelmann
2023-05-19 13:36 ` [PATCH 1/6] tests/tcg/tricore: Move asm tests into 'asm' directory Bastian Koppelmann
2023-05-19 13:36 ` [PATCH 2/6] tests/tcg/tricore: Uses label for memory addresses Bastian Koppelmann
2023-05-19 13:36 ` [PATCH 3/6] tests/tcg/tricore: Add first C program Bastian Koppelmann
2023-05-19 13:36 ` [PATCH 4/6] target/tricore: Refactor PCXI/ICR register fields Bastian Koppelmann
2023-05-19 15:02 ` Philippe Mathieu-Daudé
2023-05-19 15:18 ` Bastian Koppelmann
2023-05-20 15:10 ` Richard Henderson [this message]
2023-05-19 13:36 ` [PATCH 5/6] target/tricore: Fix wrong PSW for call insns Bastian Koppelmann
2023-05-19 13:36 ` [PATCH 6/6] tests/tcg/tricore: Add recursion test for CSAs Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f1fbb76-0d9f-769f-293d-ff346b943998@linaro.org \
--to=richard.henderson@linaro.org \
--cc=kbastian@mail.uni-paderborn.de \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).