From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] build: remove extra parentheses causing missing rebuilds
Date: Tue, 20 Sep 2022 05:58:35 +0200 [thread overview]
Message-ID: <2f2e2cdc-206f-dbaa-3c01-02ba72ae9800@linaro.org> (raw)
In-Reply-To: <20220919131723.73749-1-pbonzini@redhat.com>
On 9/19/22 15:17, Paolo Bonzini wrote:
> Because of two stray parentheses at the end of the definition of
> ninja-cmd-goals, the test that is last in the .check-TESTSUITENAME.deps
> variable will not be rebuilt. Fix that.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2022-09-20 3:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 13:17 [PATCH] build: remove extra parentheses causing missing rebuilds Paolo Bonzini
2022-09-20 3:58 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f2e2cdc-206f-dbaa-3c01-02ba72ae9800@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).